From 3e9dfd5d08439a0d7cd0faa4603fc1dd82748084 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicol=C3=B2=20Ribaudo?= Date: Wed, 19 Jun 2019 01:07:39 +0200 Subject: [PATCH 1/2] Add proposal-dynamic-import to preset-env --- .../package.json | 2 +- .../babel-preset-env-standalone/package.json | 1 + .../src/available-plugins.js | 1 + packages/babel-preset-env/package.json | 2 + .../babel-preset-env/src/available-plugins.js | 2 + packages/babel-preset-env/src/index.js | 41 +++++++++++++++---- .../input.mjs | 1 + .../options.json | 8 ++++ .../output.mjs | 1 + .../input.mjs | 1 + .../options.json | 8 ++++ .../output.mjs | 1 + .../input.mjs | 1 + .../options.json | 8 ++++ .../output.js | 7 ++++ .../dynamic-import/modules-amd/input.js | 1 + .../dynamic-import/modules-amd/options.json | 3 ++ .../dynamic-import/modules-amd/output.js | 9 ++++ .../dynamic-import/modules-cjs/input.mjs | 1 + .../dynamic-import/modules-cjs/options.json | 3 ++ .../dynamic-import/modules-cjs/output.js | 7 ++++ .../dynamic-import/modules-false/input.mjs | 1 + .../dynamic-import/modules-false/options.json | 3 ++ .../dynamic-import/modules-false/output.mjs | 1 + .../dynamic-import/modules-systemjs/input.mjs | 1 + .../modules-systemjs/options.json | 3 ++ .../modules-systemjs/output.mjs | 10 +++++ .../dynamic-import/modules-umd/input.mjs | 1 + .../dynamic-import/modules-umd/options.json | 3 ++ .../dynamic-import/modules-umd/output.js | 17 ++++++++ 30 files changed, 140 insertions(+), 9 deletions(-) create mode 100644 packages/babel-preset-env/test/fixtures/dynamic-import/auto-esm-supported-import-supported/input.mjs create mode 100644 packages/babel-preset-env/test/fixtures/dynamic-import/auto-esm-supported-import-supported/options.json create mode 100644 packages/babel-preset-env/test/fixtures/dynamic-import/auto-esm-supported-import-supported/output.mjs create mode 100644 packages/babel-preset-env/test/fixtures/dynamic-import/auto-esm-supported-import-unsupported/input.mjs create mode 100644 packages/babel-preset-env/test/fixtures/dynamic-import/auto-esm-supported-import-unsupported/options.json create mode 100644 packages/babel-preset-env/test/fixtures/dynamic-import/auto-esm-supported-import-unsupported/output.mjs create mode 100644 packages/babel-preset-env/test/fixtures/dynamic-import/auto-esm-unsupported-import-unsupported/input.mjs create mode 100644 packages/babel-preset-env/test/fixtures/dynamic-import/auto-esm-unsupported-import-unsupported/options.json create mode 100644 packages/babel-preset-env/test/fixtures/dynamic-import/auto-esm-unsupported-import-unsupported/output.js create mode 100644 packages/babel-preset-env/test/fixtures/dynamic-import/modules-amd/input.js create mode 100644 packages/babel-preset-env/test/fixtures/dynamic-import/modules-amd/options.json create mode 100644 packages/babel-preset-env/test/fixtures/dynamic-import/modules-amd/output.js create mode 100644 packages/babel-preset-env/test/fixtures/dynamic-import/modules-cjs/input.mjs create mode 100644 packages/babel-preset-env/test/fixtures/dynamic-import/modules-cjs/options.json create mode 100644 packages/babel-preset-env/test/fixtures/dynamic-import/modules-cjs/output.js create mode 100644 packages/babel-preset-env/test/fixtures/dynamic-import/modules-false/input.mjs create mode 100644 packages/babel-preset-env/test/fixtures/dynamic-import/modules-false/options.json create mode 100644 packages/babel-preset-env/test/fixtures/dynamic-import/modules-false/output.mjs create mode 100644 packages/babel-preset-env/test/fixtures/dynamic-import/modules-systemjs/input.mjs create mode 100644 packages/babel-preset-env/test/fixtures/dynamic-import/modules-systemjs/options.json create mode 100644 packages/babel-preset-env/test/fixtures/dynamic-import/modules-systemjs/output.mjs create mode 100644 packages/babel-preset-env/test/fixtures/dynamic-import/modules-umd/input.mjs create mode 100644 packages/babel-preset-env/test/fixtures/dynamic-import/modules-umd/options.json create mode 100644 packages/babel-preset-env/test/fixtures/dynamic-import/modules-umd/output.js diff --git a/packages/babel-plugin-proposal-dynamic-import/package.json b/packages/babel-plugin-proposal-dynamic-import/package.json index d4522228c579..d739301c20dc 100644 --- a/packages/babel-plugin-proposal-dynamic-import/package.json +++ b/packages/babel-plugin-proposal-dynamic-import/package.json @@ -1,6 +1,6 @@ { "name": "@babel/plugin-proposal-dynamic-import", - "version": "7.4.0", + "version": "7.5.0", "description": "Transform import() expressions", "repository": "https://github.com/babel/babel/tree/master/packages/babel-plugin-proposal-dynamic-import", "license": "MIT", diff --git a/packages/babel-preset-env-standalone/package.json b/packages/babel-preset-env-standalone/package.json index 53d20ba9bedd..68bc790227a1 100644 --- a/packages/babel-preset-env-standalone/package.json +++ b/packages/babel-preset-env-standalone/package.json @@ -9,6 +9,7 @@ "src" ], "devDependencies": { + "@babel/plugin-proposal-dynamic-import": "^7.5.0", "@babel/plugin-proposal-json-strings": "^7.0.0", "@babel/plugin-transform-named-capturing-groups-regex": "^7.4.5", "@babel/plugin-transform-new-target": "^7.4.4", diff --git a/packages/babel-preset-env-standalone/src/available-plugins.js b/packages/babel-preset-env-standalone/src/available-plugins.js index 2d41a1a0c51e..9d9e68640234 100644 --- a/packages/babel-preset-env-standalone/src/available-plugins.js +++ b/packages/babel-preset-env-standalone/src/available-plugins.js @@ -4,6 +4,7 @@ const notIncludedPlugins = { "transform-named-capturing-groups-regex": require("@babel/plugin-transform-named-capturing-groups-regex"), "transform-new-target": require("@babel/plugin-transform-new-target"), "proposal-json-strings": require("@babel/plugin-proposal-json-strings"), + "proposal-dynamic-import": require("@babel/plugin-proposal-dynamic-import"), }; Object.keys(notIncludedPlugins).forEach(pluginName => { diff --git a/packages/babel-preset-env/package.json b/packages/babel-preset-env/package.json index c87071b66eb2..fa1be265aa25 100644 --- a/packages/babel-preset-env/package.json +++ b/packages/babel-preset-env/package.json @@ -17,11 +17,13 @@ "@babel/helper-module-imports": "^7.0.0", "@babel/helper-plugin-utils": "^7.0.0", "@babel/plugin-proposal-async-generator-functions": "^7.2.0", + "@babel/plugin-proposal-dynamic-import": "^7.5.0", "@babel/plugin-proposal-json-strings": "^7.2.0", "@babel/plugin-proposal-object-rest-spread": "^7.4.4", "@babel/plugin-proposal-optional-catch-binding": "^7.2.0", "@babel/plugin-proposal-unicode-property-regex": "^7.4.4", "@babel/plugin-syntax-async-generators": "^7.2.0", + "@babel/plugin-syntax-dynamic-import": "^7.2.0", "@babel/plugin-syntax-json-strings": "^7.2.0", "@babel/plugin-syntax-object-rest-spread": "^7.2.0", "@babel/plugin-syntax-optional-catch-binding": "^7.2.0", diff --git a/packages/babel-preset-env/src/available-plugins.js b/packages/babel-preset-env/src/available-plugins.js index 1ddb9c85220b..77da4ff02cf0 100644 --- a/packages/babel-preset-env/src/available-plugins.js +++ b/packages/babel-preset-env/src/available-plugins.js @@ -2,11 +2,13 @@ export default { "syntax-async-generators": require("@babel/plugin-syntax-async-generators"), + "syntax-dynamic-import": require("@babel/plugin-syntax-dynamic-import"), "syntax-json-strings": require("@babel/plugin-syntax-json-strings"), "syntax-object-rest-spread": require("@babel/plugin-syntax-object-rest-spread"), "syntax-optional-catch-binding": require("@babel/plugin-syntax-optional-catch-binding"), "transform-async-to-generator": require("@babel/plugin-transform-async-to-generator"), "proposal-async-generator-functions": require("@babel/plugin-proposal-async-generator-functions"), + "proposal-dynamic-import": require("@babel/plugin-proposal-dynamic-import"), "proposal-json-strings": require("@babel/plugin-proposal-json-strings"), "transform-arrow-functions": require("@babel/plugin-transform-arrow-functions"), "transform-block-scoped-functions": require("@babel/plugin-transform-block-scoped-functions"), diff --git a/packages/babel-preset-env/src/index.js b/packages/babel-preset-env/src/index.js index a31f8b989741..c1979e23ac76 100644 --- a/packages/babel-preset-env/src/index.js +++ b/packages/babel-preset-env/src/index.js @@ -60,6 +60,10 @@ function supportsStaticESM(caller) { return !!(caller && caller.supportsStaticESM); } +function supportsDynamicImport(caller) { + return !!(caller && caller.supportsDynamicImport); +} + export default declare((api, opts) => { api.assertVersion(7); @@ -124,16 +128,37 @@ export default declare((api, opts) => { const plugins = []; const pluginUseBuiltIns = useBuiltIns !== false; - if ( - modules !== false && - moduleTransformations[modules] && + if (modules !== false && moduleTransformations[modules]) { // TODO: Remove the 'api.caller' check eventually. Just here to prevent // unnecessary breakage in the short term for users on older betas/RCs. - (modules !== "auto" || !api.caller || !api.caller(supportsStaticESM)) - ) { - // NOTE: not giving spec here yet to avoid compatibility issues when - // transform-modules-commonjs gets its spec mode - plugins.push([getPlugin(moduleTransformations[modules]), { loose }]); + const shouldTransformESM = + modules !== "auto" || !api.caller || !api.caller(supportsStaticESM); + const shouldTransformDynamicImport = + modules !== "auto" || !api.caller || !api.caller(supportsDynamicImport); + + if (shouldTransformESM) { + // NOTE: not giving spec here yet to avoid compatibility issues when + // transform-modules-commonjs gets its spec mode + plugins.push([getPlugin(moduleTransformations[modules]), { loose }]); + } + + if ( + shouldTransformDynamicImport && + shouldTransformESM && + modules !== "umd" + ) { + plugins.push([getPlugin("proposal-dynamic-import"), { loose }]); + } else { + if (shouldTransformDynamicImport) { + console.warn( + "Dynamic import can only be supported when transforming ES modules" + + " to amd, commonjs or systemjs. Only the parser plugin will be enabled.", + ); + } + plugins.push(getPlugin("syntax-dynamic-import")); + } + } else { + plugins.push(getPlugin("syntax-dynamic-import")); } transformations.forEach(pluginName => diff --git a/packages/babel-preset-env/test/fixtures/dynamic-import/auto-esm-supported-import-supported/input.mjs b/packages/babel-preset-env/test/fixtures/dynamic-import/auto-esm-supported-import-supported/input.mjs new file mode 100644 index 000000000000..99223a45b37d --- /dev/null +++ b/packages/babel-preset-env/test/fixtures/dynamic-import/auto-esm-supported-import-supported/input.mjs @@ -0,0 +1 @@ +import("foo"); diff --git a/packages/babel-preset-env/test/fixtures/dynamic-import/auto-esm-supported-import-supported/options.json b/packages/babel-preset-env/test/fixtures/dynamic-import/auto-esm-supported-import-supported/options.json new file mode 100644 index 000000000000..154ea4199025 --- /dev/null +++ b/packages/babel-preset-env/test/fixtures/dynamic-import/auto-esm-supported-import-supported/options.json @@ -0,0 +1,8 @@ +{ + "caller": { + "name": "test-fixture", + "supportsStaticESM": true, + "supportsDynamicImport": true + }, + "presets": ["env"] +} diff --git a/packages/babel-preset-env/test/fixtures/dynamic-import/auto-esm-supported-import-supported/output.mjs b/packages/babel-preset-env/test/fixtures/dynamic-import/auto-esm-supported-import-supported/output.mjs new file mode 100644 index 000000000000..99223a45b37d --- /dev/null +++ b/packages/babel-preset-env/test/fixtures/dynamic-import/auto-esm-supported-import-supported/output.mjs @@ -0,0 +1 @@ +import("foo"); diff --git a/packages/babel-preset-env/test/fixtures/dynamic-import/auto-esm-supported-import-unsupported/input.mjs b/packages/babel-preset-env/test/fixtures/dynamic-import/auto-esm-supported-import-unsupported/input.mjs new file mode 100644 index 000000000000..9261e2a807b7 --- /dev/null +++ b/packages/babel-preset-env/test/fixtures/dynamic-import/auto-esm-supported-import-unsupported/input.mjs @@ -0,0 +1 @@ +import("foo"); // warns diff --git a/packages/babel-preset-env/test/fixtures/dynamic-import/auto-esm-supported-import-unsupported/options.json b/packages/babel-preset-env/test/fixtures/dynamic-import/auto-esm-supported-import-unsupported/options.json new file mode 100644 index 000000000000..c444f60ae955 --- /dev/null +++ b/packages/babel-preset-env/test/fixtures/dynamic-import/auto-esm-supported-import-unsupported/options.json @@ -0,0 +1,8 @@ +{ + "caller": { + "name": "test-fixture", + "supportsStaticESM": true, + "supportsDynamicImport": false + }, + "presets": ["env"] +} diff --git a/packages/babel-preset-env/test/fixtures/dynamic-import/auto-esm-supported-import-unsupported/output.mjs b/packages/babel-preset-env/test/fixtures/dynamic-import/auto-esm-supported-import-unsupported/output.mjs new file mode 100644 index 000000000000..9261e2a807b7 --- /dev/null +++ b/packages/babel-preset-env/test/fixtures/dynamic-import/auto-esm-supported-import-unsupported/output.mjs @@ -0,0 +1 @@ +import("foo"); // warns diff --git a/packages/babel-preset-env/test/fixtures/dynamic-import/auto-esm-unsupported-import-unsupported/input.mjs b/packages/babel-preset-env/test/fixtures/dynamic-import/auto-esm-unsupported-import-unsupported/input.mjs new file mode 100644 index 000000000000..99223a45b37d --- /dev/null +++ b/packages/babel-preset-env/test/fixtures/dynamic-import/auto-esm-unsupported-import-unsupported/input.mjs @@ -0,0 +1 @@ +import("foo"); diff --git a/packages/babel-preset-env/test/fixtures/dynamic-import/auto-esm-unsupported-import-unsupported/options.json b/packages/babel-preset-env/test/fixtures/dynamic-import/auto-esm-unsupported-import-unsupported/options.json new file mode 100644 index 000000000000..370b48e76fb2 --- /dev/null +++ b/packages/babel-preset-env/test/fixtures/dynamic-import/auto-esm-unsupported-import-unsupported/options.json @@ -0,0 +1,8 @@ +{ + "caller": { + "name": "test-fixture", + "supportsStaticESM": false, + "supportsSynamicImport": false + }, + "presets": ["env"] +} diff --git a/packages/babel-preset-env/test/fixtures/dynamic-import/auto-esm-unsupported-import-unsupported/output.js b/packages/babel-preset-env/test/fixtures/dynamic-import/auto-esm-unsupported-import-unsupported/output.js new file mode 100644 index 000000000000..9c2292edabb1 --- /dev/null +++ b/packages/babel-preset-env/test/fixtures/dynamic-import/auto-esm-unsupported-import-unsupported/output.js @@ -0,0 +1,7 @@ +"use strict"; + +function _interopRequireWildcard(obj) { if (obj && obj.__esModule) { return obj; } else { var newObj = {}; if (obj != null) { for (var key in obj) { if (Object.prototype.hasOwnProperty.call(obj, key)) { var desc = Object.defineProperty && Object.getOwnPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : {}; if (desc.get || desc.set) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } } newObj["default"] = obj; return newObj; } } + +Promise.resolve().then(function () { + return _interopRequireWildcard(require("foo")); +}); diff --git a/packages/babel-preset-env/test/fixtures/dynamic-import/modules-amd/input.js b/packages/babel-preset-env/test/fixtures/dynamic-import/modules-amd/input.js new file mode 100644 index 000000000000..99223a45b37d --- /dev/null +++ b/packages/babel-preset-env/test/fixtures/dynamic-import/modules-amd/input.js @@ -0,0 +1 @@ +import("foo"); diff --git a/packages/babel-preset-env/test/fixtures/dynamic-import/modules-amd/options.json b/packages/babel-preset-env/test/fixtures/dynamic-import/modules-amd/options.json new file mode 100644 index 000000000000..e34f77e9664c --- /dev/null +++ b/packages/babel-preset-env/test/fixtures/dynamic-import/modules-amd/options.json @@ -0,0 +1,3 @@ +{ + "presets": [["env", { "modules": "amd" }]] +} diff --git a/packages/babel-preset-env/test/fixtures/dynamic-import/modules-amd/output.js b/packages/babel-preset-env/test/fixtures/dynamic-import/modules-amd/output.js new file mode 100644 index 000000000000..07297795f680 --- /dev/null +++ b/packages/babel-preset-env/test/fixtures/dynamic-import/modules-amd/output.js @@ -0,0 +1,9 @@ +define(["require"], function (_require) { + function _interopRequireWildcard(obj) { if (obj && obj.__esModule) { return obj; } else { var newObj = {}; if (obj != null) { for (var key in obj) { if (Object.prototype.hasOwnProperty.call(obj, key)) { var desc = Object.defineProperty && Object.getOwnPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : {}; if (desc.get || desc.set) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } } newObj["default"] = obj; return newObj; } } + + new Promise(function (_resolve, _reject) { + return _require(["foo"], function (imported) { + return _resolve(_interopRequireWildcard(imported)); + }, _reject); + }); +}); diff --git a/packages/babel-preset-env/test/fixtures/dynamic-import/modules-cjs/input.mjs b/packages/babel-preset-env/test/fixtures/dynamic-import/modules-cjs/input.mjs new file mode 100644 index 000000000000..99223a45b37d --- /dev/null +++ b/packages/babel-preset-env/test/fixtures/dynamic-import/modules-cjs/input.mjs @@ -0,0 +1 @@ +import("foo"); diff --git a/packages/babel-preset-env/test/fixtures/dynamic-import/modules-cjs/options.json b/packages/babel-preset-env/test/fixtures/dynamic-import/modules-cjs/options.json new file mode 100644 index 000000000000..1b03b37c6f6d --- /dev/null +++ b/packages/babel-preset-env/test/fixtures/dynamic-import/modules-cjs/options.json @@ -0,0 +1,3 @@ +{ + "presets": [["env", { "modules": "cjs" }]] +} diff --git a/packages/babel-preset-env/test/fixtures/dynamic-import/modules-cjs/output.js b/packages/babel-preset-env/test/fixtures/dynamic-import/modules-cjs/output.js new file mode 100644 index 000000000000..9c2292edabb1 --- /dev/null +++ b/packages/babel-preset-env/test/fixtures/dynamic-import/modules-cjs/output.js @@ -0,0 +1,7 @@ +"use strict"; + +function _interopRequireWildcard(obj) { if (obj && obj.__esModule) { return obj; } else { var newObj = {}; if (obj != null) { for (var key in obj) { if (Object.prototype.hasOwnProperty.call(obj, key)) { var desc = Object.defineProperty && Object.getOwnPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : {}; if (desc.get || desc.set) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } } newObj["default"] = obj; return newObj; } } + +Promise.resolve().then(function () { + return _interopRequireWildcard(require("foo")); +}); diff --git a/packages/babel-preset-env/test/fixtures/dynamic-import/modules-false/input.mjs b/packages/babel-preset-env/test/fixtures/dynamic-import/modules-false/input.mjs new file mode 100644 index 000000000000..99223a45b37d --- /dev/null +++ b/packages/babel-preset-env/test/fixtures/dynamic-import/modules-false/input.mjs @@ -0,0 +1 @@ +import("foo"); diff --git a/packages/babel-preset-env/test/fixtures/dynamic-import/modules-false/options.json b/packages/babel-preset-env/test/fixtures/dynamic-import/modules-false/options.json new file mode 100644 index 000000000000..3c22b6872e58 --- /dev/null +++ b/packages/babel-preset-env/test/fixtures/dynamic-import/modules-false/options.json @@ -0,0 +1,3 @@ +{ + "presets": [["env", { "modules": false }]] +} diff --git a/packages/babel-preset-env/test/fixtures/dynamic-import/modules-false/output.mjs b/packages/babel-preset-env/test/fixtures/dynamic-import/modules-false/output.mjs new file mode 100644 index 000000000000..99223a45b37d --- /dev/null +++ b/packages/babel-preset-env/test/fixtures/dynamic-import/modules-false/output.mjs @@ -0,0 +1 @@ +import("foo"); diff --git a/packages/babel-preset-env/test/fixtures/dynamic-import/modules-systemjs/input.mjs b/packages/babel-preset-env/test/fixtures/dynamic-import/modules-systemjs/input.mjs new file mode 100644 index 000000000000..99223a45b37d --- /dev/null +++ b/packages/babel-preset-env/test/fixtures/dynamic-import/modules-systemjs/input.mjs @@ -0,0 +1 @@ +import("foo"); diff --git a/packages/babel-preset-env/test/fixtures/dynamic-import/modules-systemjs/options.json b/packages/babel-preset-env/test/fixtures/dynamic-import/modules-systemjs/options.json new file mode 100644 index 000000000000..9be6fdb3812e --- /dev/null +++ b/packages/babel-preset-env/test/fixtures/dynamic-import/modules-systemjs/options.json @@ -0,0 +1,3 @@ +{ + "presets": [["env", { "modules": "systemjs" }]] +} diff --git a/packages/babel-preset-env/test/fixtures/dynamic-import/modules-systemjs/output.mjs b/packages/babel-preset-env/test/fixtures/dynamic-import/modules-systemjs/output.mjs new file mode 100644 index 000000000000..6fbdfb301c4e --- /dev/null +++ b/packages/babel-preset-env/test/fixtures/dynamic-import/modules-systemjs/output.mjs @@ -0,0 +1,10 @@ +System.register([], function (_export, _context) { + "use strict"; + + return { + setters: [], + execute: function () { + _context["import"]("foo"); + } + }; +}); diff --git a/packages/babel-preset-env/test/fixtures/dynamic-import/modules-umd/input.mjs b/packages/babel-preset-env/test/fixtures/dynamic-import/modules-umd/input.mjs new file mode 100644 index 000000000000..9261e2a807b7 --- /dev/null +++ b/packages/babel-preset-env/test/fixtures/dynamic-import/modules-umd/input.mjs @@ -0,0 +1 @@ +import("foo"); // warns diff --git a/packages/babel-preset-env/test/fixtures/dynamic-import/modules-umd/options.json b/packages/babel-preset-env/test/fixtures/dynamic-import/modules-umd/options.json new file mode 100644 index 000000000000..da7772e2d584 --- /dev/null +++ b/packages/babel-preset-env/test/fixtures/dynamic-import/modules-umd/options.json @@ -0,0 +1,3 @@ +{ + "presets": [["env", { "modules": "umd" }]] +} diff --git a/packages/babel-preset-env/test/fixtures/dynamic-import/modules-umd/output.js b/packages/babel-preset-env/test/fixtures/dynamic-import/modules-umd/output.js new file mode 100644 index 000000000000..f66adb1fb317 --- /dev/null +++ b/packages/babel-preset-env/test/fixtures/dynamic-import/modules-umd/output.js @@ -0,0 +1,17 @@ +(function (global, factory) { + if (typeof define === "function" && define.amd) { + define([], factory); + } else if (typeof exports !== "undefined") { + factory(); + } else { + var mod = { + exports: {} + }; + factory(); + global.input = mod.exports; + } +})(this, function () { + "use strict"; + + import("foo"); // warns +}); From ce617e0683b11828435879c846e4f6990a0e8cc2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicol=C3=B2=20Ribaudo?= Date: Wed, 26 Jun 2019 00:16:15 +0200 Subject: [PATCH 2/2] Use proper capitalization --- packages/babel-preset-env/src/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/babel-preset-env/src/index.js b/packages/babel-preset-env/src/index.js index c1979e23ac76..85a784476b83 100644 --- a/packages/babel-preset-env/src/index.js +++ b/packages/babel-preset-env/src/index.js @@ -152,7 +152,7 @@ export default declare((api, opts) => { if (shouldTransformDynamicImport) { console.warn( "Dynamic import can only be supported when transforming ES modules" + - " to amd, commonjs or systemjs. Only the parser plugin will be enabled.", + " to AMD, CommonJS or SystemJS. Only the parser plugin will be enabled.", ); } plugins.push(getPlugin("syntax-dynamic-import"));