From af44ac33e5d2161f9c264983c13617c1c1d7a0b0 Mon Sep 17 00:00:00 2001 From: Erik Arvidsson Date: Fri, 21 Jun 2019 14:19:02 -0700 Subject: [PATCH] Simplify the helpers for classPrivateField{Get,Set} No need to do the hash lookup twice. If the descriptor is not in the WeakMap `get` returns `undefined`. --- packages/babel-helpers/src/helpers.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/babel-helpers/src/helpers.js b/packages/babel-helpers/src/helpers.js index 99eab0132ad0..21c082cc40f6 100644 --- a/packages/babel-helpers/src/helpers.js +++ b/packages/babel-helpers/src/helpers.js @@ -1070,10 +1070,10 @@ helpers.classPrivateFieldLooseBase = helper("7.0.0-beta.0")` helpers.classPrivateFieldGet = helper("7.0.0-beta.0")` export default function _classPrivateFieldGet(receiver, privateMap) { - if (!privateMap.has(receiver)) { + var descriptor = privateMap.get(receiver); + if (!descriptor) { throw new TypeError("attempted to get private field on non-instance"); } - var descriptor = privateMap.get(receiver); if (descriptor.get) { return descriptor.get.call(receiver); } @@ -1083,10 +1083,10 @@ helpers.classPrivateFieldGet = helper("7.0.0-beta.0")` helpers.classPrivateFieldSet = helper("7.0.0-beta.0")` export default function _classPrivateFieldSet(receiver, privateMap, value) { - if (!privateMap.has(receiver)) { + var descriptor = privateMap.get(receiver); + if (!descriptor) { throw new TypeError("attempted to set private field on non-instance"); } - var descriptor = privateMap.get(receiver); if (descriptor.set) { descriptor.set.call(receiver, value); } else {