add scope to TSModuleDeclaration #10119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| SCOPE_SUPER = 0b0001000000, | ||
| SCOPE_DIRECT_SUPER = 0b0010000000, | ||
| SCOPE_CLASS = 0b0100000000, | ||
| SCOPE_MODULE_DECLARATION = 0b1000000000, |
There was a problem hiding this comment.
Can you prefix this with TS, like for the binding kinds? SCOPE_TS_MODULE
| declare class foo { | ||
| } | ||
| declare module 'bar' { | ||
| export var foo: any; // Identifier 'foo' has already been declared |
There was a problem hiding this comment.
Does it work without declare?
There was a problem hiding this comment.
is that a valid syntax?
There was a problem hiding this comment.
Only with an identifier name instead of a string:
https://www.typescriptlang.org/play/#src=module%20foo%20%7B%0A%20%20%20%20var%20a%20%3D%202%3B%0A%7D%0A
There was a problem hiding this comment.
oh okay, added a test case for that
tanhauhau
force-pushed
the
tanhauhau/ts-module-declaration
branch
from
bc2db77
to
070ca1e
Compare
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11482/ |
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10997/ |
tanhauhau
force-pushed
the
tanhauhau/ts-module-declaration
branch
from
070ca1e
to
5cf7f99
Compare
nicolo-ribaudo
approved these changes
Jun 27, 2019
nicolo-ribaudo
added
area: typescript
pkg: parser
PR: Bug Fix 🐛
tanhauhau
force-pushed
the
tanhauhau/ts-module-declaration
branch
from
5cf7f99
to
659621d
Compare
nicolo-ribaudo
force-pushed
the
tanhauhau/ts-module-declaration
branch
from
659621d
to
f92af4e
Compare
This was referenced Oct 22, 2019
This was referenced Nov 12, 2019
This was referenced Nov 28, 2019
This was referenced Dec 5, 2019
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new scope for TSModuleDeclaration