Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix import typeof in declare module #10132

Merged
merged 1 commit into from Jun 26, 2019
Merged

fix import typeof in declare module #10132

merged 1 commit into from Jun 26, 2019

Conversation

tanhauhau
Copy link
Member

Q                       A
Fixed Issues? Fixes #10124
Patch: Bug Fix? 👍
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Regression bug in 7.4.5, introduced by #9987, fyi @danez

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11010/

@nicolo-ribaudo nicolo-ribaudo added area: flow PR: Bug Fix 🐛 A type of pull request used for our changelog categories i: regression labels Jun 26, 2019
@existentialism existentialism merged commit 1d3f981 into babel:master Jun 26, 2019
@lydell
Copy link
Contributor

lydell commented Jun 26, 2019

Wow, thanks for the quick fix! 💯

@lydell lydell mentioned this pull request Jun 26, 2019
Closed
@tanhauhau tanhauhau deleted the tanhauhau/fix-flow-typeof-import branch June 27, 2019 13:35
@Nate-Wilkins
Copy link

@tanhauhau or @existentialism 👍 How would we go about using this? Does @babel/parser/@babel/* have some sort of release cycle or process that I could test out the new changes on my repository?

@tanhauhau tanhauhau restored the tanhauhau/fix-flow-typeof-import branch July 3, 2019 02:50
@tanhauhau tanhauhau deleted the tanhauhau/fix-flow-typeof-import branch July 3, 2019 02:50
@tanhauhau tanhauhau restored the tanhauhau/fix-flow-typeof-import branch July 3, 2019 02:50
@tanhauhau tanhauhau deleted the tanhauhau/fix-flow-typeof-import branch July 3, 2019 02:50
@existentialism
Copy link
Member

@Nate-Wilkins we're prepping the release of 7.5.0, should go out today

@snyk-bot snyk-bot mentioned this pull request Aug 20, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Sep 23, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Oct 3, 2019
Open
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
area: flow i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parse error on import typeof in declare module
6 participants
@tanhauhau @babel-bot @lydell @Nate-Wilkins @existentialism @nicolo-ribaudo