fix capturing group for matchAll

[tanhauhau]

Q	A
Fixed Issues?	Fixes #10134
Patch: Bug Fix?	👍
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?	Yes
Documentation PR Link
Any Dependency Changes?
License	MIT

According to spec (https://github.com/tc39/proposal-string-matchall/blob/master/spec.md#stringprototypematchall--regexp-), when calling String.matchAll, the regex is recreated again with 'g' flag, and the current BabelRegExp constructor will take the 'g' flag as group descriptor.

I see there's no String.prototype.matchAll support in node.js, not sure how to test this

[babel-bot]

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11199/

[nicolo-ribaudo]

In node 12 it is supported: you can use minNodeVersion in the test options.
Also, we should have another fixture to test it loading the core-js/features/string/match-all polyfill.

[tanhauhau]

@nicolo-ribaudo apparently we dont have node 12 for the test env, https://github.com/babel/babel/blob/master/.travis.yml#L8 . somehow, it's supposed to be added here 80a5a2e, but the node env for travis is node 11, not node 12

[jridgewell]

We can add node 12 to the Travis yaml

[existentialism]

@tanhauhau we test node 12 via circle:

https://github.com/babel/babel/blob/master/.circleci/config.yml#L37

[tanhauhau]

@nicolo-ribaudo how do i add core-js/features/string/match-all polyfill into the fixture?

[nicolo-ribaudo]

Doesn't adding it to the dev dependencies and then requireing it work?

[mrtnzlml]

Hi, thanks so much for taking care of my reported issue. Is there anything I can do to help with moving it forward?

[tanhauhau]

@mrtnzlml thanks for nudging, @nicolo-ribaudo i've added another fixture that test with core-js@v3 String.matchAll polyfill

[existentialism]

Shouldn't this be a devDependency?

[tanhauhau]

oops.. updated @existentialism

[nicolo-ribaudo]

I tried to use GitHub's "delete file" feature, thinking that it would have reverted the changes to a single file. I messed it up 😅

[nicolo-ribaudo]

Apart for that, this PR looks good

[mrtnzlml]

Hi @nicolo-ribaudo, me again... 😊 Would you please consider merging this PR into master?

[nicolo-ribaudo]

@mrtnzlml We have a two-:heavy_check_mark:s policy for merging PRs; I'll try to find some reviewers!

[existentialism]

I was just waiting on the revert of the package.json to +1

[tanhauhau]

Sorry my bad. fixed the wrong changes and reverts on package.json