Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added es3 backward compatibility for react helper code #10155

Merged
merged 2 commits into from Jul 3, 2019

Conversation

sormy
Copy link
Contributor

@sormy sormy commented Jul 2, 2019

Q                       A
Fixed Issues? Fixes #10145
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Yes
Documentation PR Link N/A
Any Dependency Changes? No
License MIT

Small code style fix to escape Symbol.for for compatibility with ES3.

@nicolo-ribaudo nicolo-ribaudo added area: helpers PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Jul 3, 2019
@nicolo-ribaudo
Copy link
Member

The failing tests on circleci are because this PR is based on an old version of mastre. It will work once merged.

@nicolo-ribaudo nicolo-ribaudo merged commit 5b86353 into babel:master Jul 3, 2019
@sormy
Copy link
Contributor Author

sormy commented Jul 3, 2019

I'm apologize. Did not realize that I rebased commit on top of wrong master.

@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: helpers outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories Priority: High
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@babel/helpers JSX code is not compatible with ES3
3 participants