Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect usage of $o instead of %o in debug #10157

Merged
merged 1 commit into from Jul 3, 2019
Merged

Fix incorrect usage of $o instead of %o in debug #10157

merged 1 commit into from Jul 3, 2019

Conversation

ChlorideCull
Copy link
Contributor

It would end up printing the literal "$o" instead of the directory name.

Q                       A
Fixed Issues?
Patch: Bug Fix? 👍
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

When running with debug I saw that the root config loader wouldn't print the directory properly, instead printing $o. In other words, it would print the following:

babel:config:loading:files:configuration Found root config 'babel.config.js' in $o. C:\Src\Proj +0ms

Decided to do a quick fix.

It would end up printing the literal "$o" instead of the directory name.
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11035/

@nicolo-ribaudo
Copy link
Member

Thanks!

@nicolo-ribaudo nicolo-ribaudo merged commit 595a349 into babel:master Jul 3, 2019
@nicolo-ribaudo nicolo-ribaudo added the PR: Polish 💅 A type of pull request used for our changelog categories label Jul 3, 2019
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Polish 💅 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants