Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: register inserted class declaration #10302

Merged
merged 2 commits into from Aug 8, 2019

Conversation

thiagoarrais
Copy link
Contributor

Q                       A
Fixed Issues? Fixes #10264
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? No
License MIT

This fixes the warning generated by transform-typescript regarding the class declaration created by proposal-decorators by registering the class in scope.

Related: #10172

For compatibility with the Typescript plugin

Fixes babel#10264
@thiagoarrais thiagoarrais added PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Decorators (Legacy) labels Aug 5, 2019
@babel-bot
Copy link
Collaborator

babel-bot commented Aug 5, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11287/

@keyz
Copy link
Contributor

keyz commented Sep 1, 2019

Would love to see a release being cut for this (@babel/plugin-proposal-decorators).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Decorators (Legacy)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to resolve the warning when use @babel/plugin-transform-typescript to compile typescript
5 participants