Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] jsx helper calls order #10307

Conversation

Sinewyk
Copy link
Contributor

@Sinewyk Sinewyk commented Aug 8, 2019

Q                       A
Fixed Issues? N/A
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

The jsx helper used in the babel-plugin-transform-react-inline-elements was actually not perfectly imitating the react behavior as seen here.

In particular, the order is resolve the children, then resolve the defaultProps. Not the opposite.

I had a bug with defaultProps: { children: null } that was appearing only when in production (when using the babel-plugin-transform-react-inline-elements), my children were undefined (which is an invariant error) even though I had defaultProps. This is the reason.

imitate properly react createElement calls order
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11291/

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JLHwung JLHwung added area: jsx PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Aug 8, 2019
@nicolo-ribaudo nicolo-ribaudo merged commit a112be2 into babel:master Aug 8, 2019
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: jsx outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants