Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flow comments plugin issues #10329

Merged
merged 5 commits into from Aug 14, 2019
Merged

Fix flow comments plugin issues #10329

merged 5 commits into from Aug 14, 2019

Conversation

zaygraveyard
Copy link
Contributor

Q                       A
Fixed Issues? Fixes #10324, Fixes #10323, Fixes #10321
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? No
License MIT

Fix issues in plugin-transform-flow-comments where some comments might get lost or have their position changed.
And add support for correctly handling extends keyword in the class declaration.

@zaygraveyard
Copy link
Contributor Author

Does anyone know why is the CI build failing?

@nicolo-ribaudo
Copy link
Member

Yeah ignore CircleCI, it should be fixed by 0519650

@nicolo-ribaudo nicolo-ribaudo added area: flow PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Aug 13, 2019
@zaygraveyard
Copy link
Contributor Author

@nicolo-ribaudo Thank you
Is it better to rebase this PR on top this fix?

@nicolo-ribaudo
Copy link
Member

Yeah it would be appreciated but not needed

@babel-bot
Copy link
Collaborator

babel-bot commented Aug 13, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11323/

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: flow outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
4 participants