Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit generated code #10331

Merged
merged 2 commits into from Aug 13, 2019
Merged

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Aug 13, 2019

Q                       A
Fixed Issues? Commit generated code artifacts
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

The generated code artifacts should be committed. I am wondering if we could add an extra step

git diff-index --quiet HEAD --

after make bootstrap in CI so that we can remind people there are artifacts changes need to be committed.

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Aug 13, 2019
@nicolo-ribaudo
Copy link
Member

We could do it with GH actions, to test them.
I have added you to https://github.com/babel/test-github-actions in case you want to test them.

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11315/

@nicolo-ribaudo nicolo-ribaudo merged commit 22df2ae into babel:master Aug 13, 2019
@JLHwung JLHwung deleted the commit-generated-code branch August 13, 2019 15:17
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants