fix: allow the process to exit naturally #10400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Bug Fix 🐛
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11481/ |
JLHwung
force-pushed
the
allow-process-exit-naturally
branch
from
91bc795
to
f285dcf
Compare
nicolo-ribaudo
approved these changes
Sep 6, 2019
danez
approved these changes
Sep 11, 2019
This was referenced Oct 2, 2019
This was referenced Oct 22, 2019
This was referenced Nov 28, 2019
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
process.exit()would terminate the process as soon as possible even when there are pending asynchronous I/O operations. It could lead to truncated error logs when I/O device is slow or the error log is big.In this PR we replace
process.exit()by settingprocess.exitCode. Doing so and avoiding scheduling more tasks to event loop will allow the process to exit naturally.