Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove circular dependency #10405

Merged
merged 2 commits into from Sep 8, 2019
Merged

Conversation

nicolo-ribaudo
Copy link
Member

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Wile running make publish, I got the updated version of the cyrcular deps warnings:

lerna info execute Skipping releases
lerna WARN ECYCLE Dependency cycles detected, you should fix these!
lerna WARN ECYCLE @babel/core -> @babel/helper-transform-fixture-test-runner -> @babel/core
lerna WARN ECYCLE @babel/generator -> @babel/types -> @babel/generator
lerna WARN ECYCLE @babel/plugin-transform-runtime -> @babel/plugin-transform-runtime
lerna WARN ECYCLE @babel/register -> (nested cycle: @babel/core -> @babel/helper-transform-fixture-test-runner -> @babel/core) -> @babel/register
lerna WARN ECYCLE (nested cycle: @babel/register -> (nested cycle: @babel/core -> @babel/helper-transform-fixture-test-runner -> @babel/core) -> @babel/register) -> (nested cycle: @babel/register -> (nested cycle: @babel/core -> @babel/helper-transform-fixture-test-runner -> @babel/core) -> @babel/register)
lerna info git Pushing tags...
lerna success version finished

(it will also be used by make bootstrap when lerna/lerna#2224 is merged)

The cycle removed in this PR was really easy (and probably the only one worth removing), since it was unused 😛

@nicolo-ribaudo nicolo-ribaudo added the PR: Internal 🏠 A type of pull request used for our changelog categories label Sep 6, 2019
@babel-bot
Copy link
Collaborator

babel-bot commented Sep 6, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11503/

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11502/

@nicolo-ribaudo
Copy link
Member Author

nicolo-ribaudo commented Sep 6, 2019

Ok, I removed another one 🎉

@nicolo-ribaudo nicolo-ribaudo merged commit 6a5cee8 into babel:master Sep 8, 2019
@nicolo-ribaudo nicolo-ribaudo deleted the circular-deps branch September 8, 2019 20:53
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants