Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove trim-right dependency #10420

Merged
merged 1 commit into from Sep 10, 2019

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Sep 9, 2019

Q                       A
Fixed Issues? remove trim-right and lodash/trimEnd dependencies
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?
Documentation PR Link
Any Dependency Changes? remove trim-right and lodash/trimEnd dependencies
License MIT

String.prototype.trimRight is supported on node >= 6.5: http://kangax.github.io/compat-table/es2016plus/

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Sep 9, 2019
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11528/

Copy link
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yess less deps 👍 and using JS!

@nicolo-ribaudo nicolo-ribaudo merged commit 8183103 into babel:master Sep 10, 2019
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 10, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants