Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove babel polyfill dependency of babel-node #10429

Merged
merged 1 commit into from Sep 10, 2019
Merged

Remove babel polyfill dependency of babel-node #10429

merged 1 commit into from Sep 10, 2019

Conversation

bdwain
Copy link
Contributor

@bdwain bdwain commented Sep 10, 2019

Q                       A
Fixed Issues? Fixes #10295
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link N/A
Any Dependency Changes? Using core-js 3 and regenerator runtime instead of babel polyfill
License MIT

Since babel polyfill is deprecated, I removed the usage of it in babel/node. Instead, I switched it to use core-js@3 and regenerator-runtime (as suggested). Behavior is unchanged.

Note that one test seems to fail when running all tests, but not when running tests only for babel-node with TEST_ONLY. But this happens on the latest master too, so I assume it's unrelated to my change.

 ● bin/babel-node › node_--inspect

    Timeout - Async callback was not invoked within the 10000ms timeout specified by jest.setTimeout.Error: 

      199 |       }
      200 | 
    > 201 |       it(testName, buildTest(binName, testName, opts));
          |       ^
      202 |     });
      203 |   });
      204 | });

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11546/

@nicolo-ribaudo nicolo-ribaudo added PR: Dependency ⬆️ PR: Internal 🏠 A type of pull request used for our changelog categories area: node labels Sep 10, 2019
@nicolo-ribaudo
Copy link
Member

Thanks!

@nicolo-ribaudo nicolo-ribaudo merged commit 98b1484 into babel:master Sep 10, 2019
dword-design pushed a commit to dword-design/babel that referenced this pull request Nov 15, 2019
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 11, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: node outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Dependency ⬆️ PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

installing @babel/node@7.5.5 also install @babel/polyfill as dependency
4 participants