Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect trace position in fixture runner #10566

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Oct 16, 2019

Q                       A
Fixed Issues? Incorrect callsite position when error is thrown at the first line in the exec fixture.
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

In this PR we place the fixture code at the second line and add lineOffset to make sure the error stack position is correct.

You can check this build to see that the fixture error stack is incorrect when error is thrown at the first line.

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Oct 16, 2019
@JLHwung JLHwung force-pushed the incorrect-trace-position-in-fixture-runner branch from 9875daf to 80069c9 Compare October 16, 2019 17:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants