New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parentheses on replaceWithMultiple for JSX #10598
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
area: jsx
pkg: traverse
PR: Bug Fix 🐛
A type of pull request used for our changelog categories
labels
Oct 23, 2019
JLHwung
changed the title
Closes #9851 Fix parentheses on replaceWithMultiple for JSX
Fix parentheses on replaceWithMultiple for JSX
Oct 24, 2019
nicolo-ribaudo
approved these changes
Oct 25, 2019
CircleCI failure is not related to this PR |
@@ -97,4 +102,23 @@ describe("path/replacement", function() { | |||
); | |||
}); | |||
}); | |||
describe("replaceWithMultiple", () => { | |||
it("ReplaceWithMultiple for a JSXElement with a JSXElement parent", () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
it("ReplaceWithMultiple for a JSXElement with a JSXElement parent", () => { | |
it("does not add extra parenthesis for a JSXElement with a JSXElement parent", () => { |
existentialism
approved these changes
Oct 31, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nit, otherwise LGTM!
JLHwung
reviewed
Oct 31, 2019
JLHwung
approved these changes
Nov 9, 2019
CI error is unrelated. |
Thanks! |
This was referenced Dec 12, 2019
lock
bot
added
the
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
label
Feb 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area: jsx
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
pkg: traverse
PR: Bug Fix 🐛
A type of pull request used for our changelog categories
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaceWithMultiple()
first sets the node to replace to null then add the new nodes after it throughinsertAfter()
.insertAfter()
already checks for when the node is aJSXElement
so that it proceeds to inserting the new nodes to the container. To fix the issue, we want to also check if the parent is aJSXElement
.