Add asserts this [is type] parsing support
#10677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Bug Fix 🐛
nicolo-ribaudo
previously approved these changes
Nov 8, 2019
| }, | ||
| "body": [ | ||
| { | ||
| "type": "TSDeclareMethod", |
There was a problem hiding this comment.
Well, in that example it's correct because there isn't the method body.
There was a problem hiding this comment.
Addressed in e6bf63e.
JLHwung
commented
Nov 9, 2019
| return false; | ||
| } | ||
|
|
||
| const id = this.parseIdentifier(); | ||
| if ( |
There was a problem hiding this comment.
This is refactor of tsParseTypePredicateAsserts which aims to avoid creating node by parseIdentifier.
existentialism
approved these changes
Nov 9, 2019
nicolo-ribaudo
approved these changes
Nov 11, 2019
This was referenced Dec 5, 2019
This was referenced Dec 12, 2019
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up to #10543, this PR adds
asserts this [is type]support. In addition, it also fixes an edge case whereassertskeyword contains escaped sequence.Since we declared TypeScript 3.7 support on 7.7.0, I would expect this PR to be shipped in a patch release.