Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix optional method chaining in derived classes #10694

Conversation

shrirambalaji
Copy link
Contributor

Q                       A
Fixed Issues? Fixes #10673
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Yes
Documentation PR Link NA
Any Dependency Changes? No
License MIT

@buildsize
Copy link

buildsize bot commented Nov 10, 2019

File name Previous Size New Size Change
babel-preset-env.js 2.78 MB 2.78 MB 9 bytes (0%)
babel-preset-env.min.js 1.67 MB 1.67 MB 9 bytes (0%)
babel.js 2.96 MB 2.96 MB 132 bytes (0%)
babel.min.js 1.63 MB 1.63 MB 58 bytes (0%)
test262.tap 4.91 MB [deleted]

@existentialism existentialism added PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Optional Chaining labels Nov 11, 2019
JLHwung
JLHwung previously approved these changes Nov 12, 2019
@JLHwung JLHwung dismissed their stale review November 12, 2019 15:04

The CI failure is related to this PR.

@shrirambalaji shrirambalaji force-pushed the fix-optional-method-chaining-in-derived-classes branch from 96a231d to ddc6466 Compare November 12, 2019 15:35
@existentialism existentialism merged commit ecad667 into babel:master Nov 12, 2019
@existentialism
Copy link
Member

@Shriram-Balaji thanks! great work!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Optional Chaining
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional chaining on super.method() breaks
5 participants