New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix optional method chaining in derived classes #10694
Merged
existentialism
merged 4 commits into
babel:master
from
shrirambalaji:fix-optional-method-chaining-in-derived-classes
Nov 12, 2019
Merged
Fix optional method chaining in derived classes #10694
existentialism
merged 4 commits into
babel:master
from
shrirambalaji:fix-optional-method-chaining-in-derived-classes
Nov 12, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shrirambalaji
commented
Nov 10, 2019
Q | A |
---|---|
Fixed Issues? | Fixes #10673 |
Patch: Bug Fix? | Yes |
Major: Breaking Change? | No |
Minor: New Feature? | No |
Tests Added + Pass? | Yes |
Documentation PR Link | NA |
Any Dependency Changes? | No |
License | MIT |
jridgewell
reviewed
Nov 11, 2019
...ges/babel-plugin-proposal-optional-chaining/test/fixtures/general/super-method-call/input.js
Show resolved
Hide resolved
existentialism
added
PR: Bug Fix 🐛
A type of pull request used for our changelog categories
Spec: Optional Chaining
labels
Nov 11, 2019
JLHwung
reviewed
Nov 11, 2019
JLHwung
previously approved these changes
Nov 12, 2019
JLHwung
reviewed
Nov 12, 2019
shrirambalaji
force-pushed
the
fix-optional-method-chaining-in-derived-classes
branch
from
November 12, 2019 15:35
96a231d
to
ddc6466
Compare
JLHwung
approved these changes
Nov 12, 2019
jridgewell
approved these changes
Nov 12, 2019
@Shriram-Balaji thanks! great work! |
This was referenced Dec 12, 2019
lock
bot
added
the
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
label
Feb 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
PR: Bug Fix 🐛
A type of pull request used for our changelog categories
Spec: Optional Chaining
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.