Update preset-env mappings #10742
Update preset-env mappings #10742
Conversation
existentialism
added
pkg: preset-env
PR: Bug Fix 🐛
| @@ -6,7 +6,7 @@ | |||
| "safari": "10.1", | |||
| "opera": "48", | |||
| "ios_saf": "10.3", | |||
| "and_chr": "71", | |||
| "and_ff": "64" | |||
| "and_chr": "74", | |||
There was a problem hiding this comment.
I don't think we need to bump and_chr and and_ff because:
- CanIUse doesn't support mobile browsers versions
caniuse-dbis not bumped
There was a problem hiding this comment.
CanIUse doesn't support mobile browsers versions
What do you mean? This data is generated directly via our script?
caniuse-dbis not bumped
FWIW, if you run build-data on master, it updates these two values with the version of caniuse-db that it's pinned to. In fact, if we bump it, it'll update and_chr to 78.
There was a problem hiding this comment.
They should not be updated because caniuse does not track old mobile browser versions, so and_chr will always return the latest version of all available Android Chrome, same as and_ff. (i.e. they are bumped in this commit of caniuse-db)
Could we skip and_ff and and_chr in
There was a problem hiding this comment.
Oh, gotcha. Yep I'll make an update.
There was a problem hiding this comment.
According to #7344 (comment), it was you who explained it to me 😛
There was a problem hiding this comment.
@nicolo-ribaudo Any idea why and_chr is removed from skipList in #9978?
There was a problem hiding this comment.
Adding them to skipList would remove them from the generated output altogether
There was a problem hiding this comment.
Yeah, and it doesn't really matter since browserlists returns the desktop version anyway.
There was a problem hiding this comment.
Then we need a doNotUpdateList then. Anyway let's address it in a separate PR.
existentialism
force-pushed
the
issue-10740
branch
from
0721da5
to
22d087d
Compare
lock
bot
added
the
outdated
After this, we can rebase #10225 and land that as well.