Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filename detection should respect short flags #10763

Merged
merged 3 commits into from Jan 11, 2020
Merged

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Nov 25, 2019

Q                       A
Fixed Issues? Fixes #9349
Patch: Bug Fix? Yes
Tests Added + Pass? Yes
Any Dependency Changes? Yes, commander is bumped to v4.0.1 to be consistent with babel-cli.
License MIT

In this PR we fixed the filename detection logic by respecting the short flags (e.g. -v) other than long flags --version. The previous ad-hoc approach is thus replaced by program.options API.

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: node labels Nov 25, 2019
@JLHwung
Copy link
Contributor Author

JLHwung commented Jan 11, 2020

@JLHwung JLHwung merged commit 903ad61 into babel:master Jan 11, 2020
@JLHwung JLHwung deleted the fix-9349 branch January 11, 2020 01:46
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 11, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: node PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

babel-node -b <preset> cli flag doesn't work
2 participants