fix: rewriteBindingInitVisitor should skip on scopable node #10764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Bug Fix 🐛
nicolo-ribaudo
approved these changes
Nov 26, 2019
existentialism
approved these changes
Nov 26, 2019
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rewriteBindingInitVisitoris used in module transform helper to injectexportsstatement after ExportDeclaration. Since ExportDeclaration is only allowed in top-level scope, it should skip when it visits a scopable node. Therefore theFunctionandClassPropertyvisitor should be replaced byScopevisitor.This issue impacts all module related transforms.