refactor: Improve error message in @babel/core #10778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jaroslav-kubicek Thanks for fixing the outdated test fixtures. I have cherry-picked your fix to the master branch. Could you rebase? |
jaroslav-kubicek
force-pushed
the
improve-error-message
branch
from
9d136b9
to
8da1b35
Compare
nicolo-ribaudo
added
area: errors
PR: Polish 💅
jaroslav-kubicek
force-pushed
the
improve-error-message
branch
from
8da1b35
to
5b4c73f
Compare
JLHwung
approved these changes
Nov 30, 2019
nicolo-ribaudo
approved these changes
Nov 30, 2019
|
Thanks! |
mrtnzlml
added a commit
to adeira/universe
that referenced
this pull request
Dec 2, 2019
This feature was requested here #189 and was greatly improved in Babel itself here babel/babel#10778. It can however be annoying and sometimes difficult to do such modification so I changed my mind and I'd like to allow it after all. It's because this code where we require "upward" mode is necessary only for Universe development and should not affect users of our NPM package.
mrtnzlml
added a commit
to adeira/universe
that referenced
this pull request
Dec 2, 2019
This feature was requested here #189 and was greatly improved in Babel itself here babel/babel#10778. It can however be annoying and sometimes difficult to do such modification so I changed my mind and I'd like to allow it after all. It's because this code where we require "upward" mode is necessary only for Universe development and should not affect users of our NPM package.
mrtnzlml
added a commit
to adeira/universe
that referenced
this pull request
Dec 2, 2019
This feature was requested here #189 and was greatly improved in Babel itself here babel/babel#10778. It can however be annoying and sometimes difficult to do such modification so I changed my mind and I'd like to allow it after all. It's because this code where we require "upward" mode is necessary only for Universe development and should not affect users of our NPM package.
adeira-github-bot
pushed a commit
to adeira/relay-example
that referenced
this pull request
Dec 14, 2019
This feature was requested here adeira/universe#189 and was greatly improved in Babel itself here babel/babel#10778. It can however be annoying and sometimes difficult to do such modification so I changed my mind and I'd like to allow it after all. It's because this code where we require "upward" mode is necessary only for Universe development and should not affect users of our NPM package. adeira-source-id: a7917273c3a7861fa3f355e38c9ab732a9b1d150
This was referenced Feb 22, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
I would like to propose updating the error message when running babel with
rootMode:"upward"so user gets feedback on what's expected.Motivation:
Given I have a repository and I migrated recently to babel 7.x and still using just
.babelrcfor configuration. I ran a script provided to me by a third-party library which tried to search for my config but failed with this error. I would like to understand more about what is expected of me from an error message.