New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add allowTopLevelThis
option to transform-modules-systemjs
#10780
Merged
nicolo-ribaudo
merged 2 commits into
babel:master
from
JLHwung:allow-top-level-this-transform-modules-systemjs
Jan 10, 2020
Merged
add allowTopLevelThis
option to transform-modules-systemjs
#10780
nicolo-ribaudo
merged 2 commits into
babel:master
from
JLHwung:allow-top-level-this-transform-modules-systemjs
Jan 10, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: New Feature 🚀
A type of pull request used for our changelog categories
area: modules
labels
Nov 29, 2019
nicolo-ribaudo
approved these changes
Dec 9, 2019
existentialism
approved these changes
Dec 21, 2019
existentialism
added
the
PR: Ready to be Merged
A pull request with already two approvals, but waiting for the next minor release
label
Dec 21, 2019
@JLHwung Docs 🙏 |
nicolo-ribaudo
deleted the
allow-top-level-this-transform-modules-systemjs
branch
January 10, 2020 02:16
This was referenced Feb 22, 2020
This was referenced Mar 7, 2020
This was referenced Mar 14, 2020
This was referenced Mar 23, 2020
This was referenced Mar 31, 2020
This was referenced Apr 8, 2020
github-actions
bot
added
the
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
label
Apr 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area: modules
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
PR: Needs Docs
PR: New Feature 🚀
A type of pull request used for our changelog categories
PR: Ready to be Merged
A pull request with already two approvals, but waiting for the next minor release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@babel/plugin-transform-modules-systemjs
now depends on@babel/helper-module-transforms
.This PR adds
allowTopLevelThis
option totransform-modules-systemjs
. To be consistent with other module transforms plugin, the default value ofallowTopLevelThis
isfalse
, which means the top levelthis
will be replaced byvoid 0
by default.The spec dictates that in the module executing context,
this
is alwaysundefined
. So the default value does make it align to the specs. Though I am not sure how many people rely on the previous incompliant behaviour.