New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use chrome data when android is absent #10790
Use chrome data when android is absent #10790
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In core-js
it's implemented as https://github.com/zloirock/core-js/blob/v3.4.5/packages/core-js-compat/index.js#L41
Maybe this should be added to https://github.com/browserslist/browserslist/blob/4da6f9c683ce27816f8804663c4cd29ef38d01a7/index.js#L454? |
The existence of any |
According to the caniuse description, the My first approach was somehow similar to core-js-compat: map @zloirock Wouldn't current approach in |
@JLHwung For Android 5+ Chrome and WebView we have |
96be294
to
7402a40
Compare
packages/babel-preset-env/test/fixtures/debug/browserslists-last-2-versions-not-ie/options.json
Outdated
Show resolved
Hide resolved
|
||
Using modules transform: auto | ||
|
||
Using plugins: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plugins listed here is generated from a sort-of modern browserslist configuration. It can help us prioritize bug fixes in the current transforms. because these plugins are expected to be used for a longer time than other standard transforms.
7402a40
to
064852f
Compare
064852f
to
3a6d351
Compare
8f34d63
to
24803c0
Compare
Using targets: | ||
{ | ||
"android": "77", | ||
"chrome": "77", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recently the chrome 49 usage just drops to 0.5% and therefore excluded from browserslists defaults > 0.5%
now.
In this PR we introduce a
getLowestImplementedVersion
which adds chrome support data as fallback whenandroid
support data is absent, by doing preset-env would not introduce unnecessary transforms forAndroid >= 52
, which should share the same features sets asChrome >= 52
.The previous behaviour is revealed in this CI failure. This behaviours renders settings like
last 2 versions
unusable and preset-env will thus apply all the transforms.