Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use scope flags to check arguments #10801

Merged
merged 2 commits into from Dec 5, 2019
Merged

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Dec 3, 2019

Q                       A
Fixed Issues? Fixes #10771
Patch: Bug Fix? Y
Tests Added + Pass? Yes
License MIT

In this PR we introduce inClass accessor in ScopeHandler and use it to check arguments keyword. Please refer to this thread for the background.

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Class Fields labels Dec 3, 2019
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test with arrow functions?

class A {
  x = () => arguments;
}

@JLHwung
Copy link
Contributor Author

JLHwung commented Dec 5, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Class Fields
Projects
None yet
3 participants