Add optional-chaining and nullish-coalescing to preset-env #10811

Druotic · 2019-12-04T21:17:28Z

Q	A
Fixed Issues?	Fixes #10809
Patch: Bug Fix?	N
Major: Breaking Change?	N
Minor: New Feature?	Y
Tests Added + Pass?	Y
Documentation PR Link
Any Dependency Changes?
License	MIT

packages/babel-preset-env/data/built-in-modules.json

nicolo-ribaudo · 2019-12-04T22:08:34Z

@Druotic Could you also add nullish coalescing? 🙏

(@JLHwung you were right 😂)

JLHwung · 2019-12-04T22:09:21Z

packages/babel-preset-env/data/plugins.json

@@ -299,6 +299,10 @@
    "opera": "53",
    "electron": "3.1"
  },
+  "proposal-optional-chaining": {


We should also add a plugin syntax map to the pluginSyntaxMap

babel/packages/babel-preset-env/data/shipped-proposals.js

Line 6 in bb6cc61

const pluginSyntaxMap = new Map([

So that if babel is configured with

{ "presets": [ ["@babel/env", { "targets": { "browserslist": "chrome 80" } }] ] }

Babel would not transform them at all since it gets native support.

By doing so it means we need to add @babel/syntax-proposal-optional-chaining as dependencies, too.

Added - hopefully I did that correctly. Being new to this project - I must admit, I don't fully understand all of the machinery here, so assume the worst 😂

Thanks for the quick feedback, as well 👍

Hmm, am I correct in assuming I should also add the syntax plugin to the notIncludedPlugins in babel-present-env-standalone?

babel/packages/babel-preset-env-standalone/src/available-plugins.js

Line 3 in bb6cc61

const notIncludedPlugins = {

You are doing great! And we should also add the syntax plugin to preset-env/src/available-plugins.

Druotic · 2019-12-04T23:49:16Z

Alright - should be good for a re-review. I combined the other PR (nullish coalescing) into this one and assumed the same pattern was necessary.

nicolo-ribaudo · 2019-12-04T23:53:31Z

packages/babel-preset-env/data/plugin-features.js

  "transform-named-capturing-groups-regex": "RegExp named capture groups",
  "transform-member-expression-literals": "Object/array literal extensions / Reserved words as property names",
  "transform-property-literals": "Object/array literal extensions / Reserved words as property names",
  "transform-reserved-words": "Miscellaneous / Unreserved words",
+  "proposal-nullish-coalescing-operator": "nullish coalescing operator (??)",


Can you keep this alphabetically ordered?

Not a blocker for this PR, but would be nice if we can enforce this with ESLint, even if it's just enabling the rule using comments for this object.

Yeah that would be cool! But let's do it in a separate PR.

Oops - I didn't see this reply until after making the changes. I selectively added the sort-keys rule to a few files which resulted in some noise/sorting of existing keys. It's in a separate commit for easy review. If it's too much, I can pull it out into another PR.

It's still okay to review since the changes are related to a few files.

nicolo-ribaudo · 2019-12-04T23:53:52Z

packages/babel-preset-env/data/shipped-proposals.js

  ["proposal-unicode-property-regex", null],
  ["proposal-json-strings", "syntax-json-strings"],
+  ["proposal-nullish-coalescing-operator", "syntax-nullish-coalescing-operator"],


JLHwung

Thanks!

nicolo-ribaudo · 2019-12-05T11:32:57Z

@Druotic FYI, we will merge this PR when we are ready for the next minor release (it could take a while)

LarsDenBakker · 2019-12-05T11:47:39Z

I think a lot of people are eagerly awaiting this, any chance of doing this soonish? :)

msholty-fd · 2019-12-05T12:25:11Z

packages/babel-preset-env/data/shipped-proposals.js

@@ -3,12 +3,15 @@

 const proposalPlugins = {};

+// Please keep these in alphabetical order!


If you want to enforce these tuples being in alphabetical order, you could use /* eslint sort-keys: "error" */ like you do in available-plugins.js, and create an object representing these plugins where the order will be enforced.

Then you could transform it for the new Map():

const pluginSyntaxObject = { "proposal-async-generator-functions": "syntax-async-generators", "proposal-json-strings": "syntax-json-strings", "proposal-nullish-coalescing-operator": "syntax-nullish-coalescing-operator", "proposal-object-rest-spread": "syntax-object-rest-spread", "proposal-optional-catch-binding": "syntax-optional-catch-binding", "proposal-optional-chaining": "syntax-optional-chaining", "proposal-unicode-property-regex": null, } const pluginSyntaxMap = new Map(Object.entries(pluginSyntaxMap))

Good call - updated. I also resolved new conflicts with master.

JLHwung · 2019-12-05T16:31:33Z

Note that if you really want to test on the new language features, you can always enable these features before preset-env supports them:

Install via yarn or npm

yarn add --dev @babel/plugin-proposal-nullish-coalescing-operator @babel/plugin-proposal-optional-chaining

Add these plugins to your babel config

{
  "presets": ["@babel/preset-env"],
  "plugins": [
    "@babel/plugin-proposal-nullish-coalescing-operator",
    "@babel/plugin-proposal-optional-chaining"
  ]
}

JLHwung · 2019-12-05T19:00:11Z

packages/babel-preset-env/data/shipped-proposals.js


-module.exports = { proposalPlugins, pluginSyntaxMap };
+const pluginSyntaxMap = new Map(Object.entries(pluginSyntaxObject));


Unfortunately Object.entries is not supported in Node 6 (behind a flag), could you add a todo item and restore it to Map constructor? We can apply this change on Babel 8.

Or maybe someone could write a feature request in the eslint repo to make sort-keys work with the Map and Set constructors ☺️

Sorry for that confusion! I wasn't aware of the Object.entries limitation.

@msholty-fd I didn't realize it before I read the CI error. The discussion above is still constructive that we have new eslint rules idea.

babel/babel#10811 was merged and released in babel 7.8.0

JLHwung reviewed Dec 4, 2019

View reviewed changes

packages/babel-preset-env/data/built-in-modules.json Outdated Show resolved Hide resolved

nicolo-ribaudo added the PR: New Feature 🚀 A type of pull request used for our changelog categories label Dec 4, 2019

nicolo-ribaudo added this to the v7.8.0 milestone Dec 4, 2019

nicolo-ribaudo added pkg: preset-env Spec: Optional Chaining labels Dec 4, 2019

JLHwung reviewed Dec 4, 2019

View reviewed changes

JLHwung mentioned this pull request Dec 4, 2019

chore: map mobile browser data to their desktop version #10814

Merged

Druotic mentioned this pull request Dec 4, 2019

Add support for nullish coalescing operator in preset-env #10815

Closed

nicolo-ribaudo changed the title ~~Add support for optional-chaining (stage 4) in present-env~~ Add optional-chaining and nullish-coalescing in present-env Dec 4, 2019

nicolo-ribaudo changed the title ~~Add optional-chaining and nullish-coalescing in present-env~~ Add optional-chaining and nullish-coalescing to present-env Dec 4, 2019

nicolo-ribaudo reviewed Dec 4, 2019

View reviewed changes

JLHwung approved these changes Dec 5, 2019

View reviewed changes

existentialism approved these changes Dec 5, 2019

View reviewed changes

JLHwung added the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Dec 5, 2019

msholty-fd reviewed Dec 5, 2019

View reviewed changes

Druotic changed the title ~~Add optional-chaining and nullish-coalescing to present-env~~ Add optional-chaining and nullish-coalescing to preset-env Dec 5, 2019

JLHwung changed the base branch from master to feat-7.8/preset-env December 5, 2019 18:52

JLHwung reviewed Dec 5, 2019

View reviewed changes

nicolo-ribaudo removed the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Dec 5, 2019

JLHwung changed the base branch from feat-7.8/preset-env to master December 5, 2019 22:02

JLHwung added the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Dec 5, 2019

nicolo-ribaudo approved these changes Dec 5, 2019

View reviewed changes

LarsDenBakker mentioned this pull request Dec 8, 2019

[building] support optional chaining and nullish coalescing open-wc/open-wc#1094

Merged

sodatea mentioned this pull request Dec 12, 2019

Typescript support enhance vuejs/vue-cli#4738

Closed

bennypowers added a commit to blikblum/open-wc that referenced this pull request Mar 29, 2020

feat(es-dev-server): remove extra babel plugins

a55f7e5

babel/babel#10811 was merged and released in babel 7.8.0

github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 11, 2020

github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add optional-chaining and nullish-coalescing to preset-env #10811

Add optional-chaining and nullish-coalescing to preset-env #10811

Druotic commented Dec 4, 2019

nicolo-ribaudo commented Dec 4, 2019

JLHwung Dec 4, 2019

Druotic Dec 4, 2019 •

edited

Druotic Dec 4, 2019

JLHwung Dec 4, 2019

Druotic commented Dec 4, 2019

nicolo-ribaudo Dec 4, 2019

kaicataldo Dec 4, 2019

nicolo-ribaudo Dec 5, 2019

Druotic Dec 5, 2019 •

edited

JLHwung Dec 5, 2019

nicolo-ribaudo Dec 4, 2019

JLHwung left a comment

nicolo-ribaudo commented Dec 5, 2019

LarsDenBakker commented Dec 5, 2019

msholty-fd Dec 5, 2019 •

edited

Druotic Dec 5, 2019

JLHwung commented Dec 5, 2019

JLHwung Dec 5, 2019

nicolo-ribaudo Dec 5, 2019

msholty-fd Dec 5, 2019

JLHwung Dec 5, 2019

		@@ -3,12 +3,15 @@

		const proposalPlugins = {};

		// Please keep these in alphabetical order!


		module.exports = { proposalPlugins, pluginSyntaxMap };
		const pluginSyntaxMap = new Map(Object.entries(pluginSyntaxObject));

Navigation Menu

Add optional-chaining and nullish-coalescing to preset-env #10811

Add optional-chaining and nullish-coalescing to preset-env #10811

Conversation

Druotic commented Dec 4, 2019

nicolo-ribaudo commented Dec 4, 2019

Choose a reason for hiding this comment

Druotic Dec 4, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Druotic commented Dec 4, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Druotic Dec 5, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JLHwung left a comment

Choose a reason for hiding this comment

nicolo-ribaudo commented Dec 5, 2019

LarsDenBakker commented Dec 5, 2019

msholty-fd Dec 5, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JLHwung commented Dec 5, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Druotic Dec 4, 2019 •

edited

Druotic Dec 5, 2019 •

edited

msholty-fd Dec 5, 2019 •

edited