Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable nullish coalescing by default in @babel/parser #10819

Merged
merged 2 commits into from Jan 10, 2020

Conversation

layershifter
Copy link
Contributor

Q                       A
Fixed Issues? Fixes #10813
Patch: Bug Fix? N
Major: Breaking Change? N
Minor: New Feature? Y
Tests Added + Pass? Y
Documentation PR Link
Any Dependency Changes?
License MIT

@nicolo-ribaudo nicolo-ribaudo added pkg: parser PR: New Feature 🚀 A type of pull request used for our changelog categories Spec: Nullish Coalescing Operator labels Dec 5, 2019
@nicolo-ribaudo nicolo-ribaudo added this to the v7.8.0 milestone Dec 5, 2019
@layershifter
Copy link
Contributor Author

layershifter commented Dec 5, 2019

Hey folks, do you have any ideas why CI fails on this test? 🤔

 FAIL  packages/babel-preset-env/test/targets-parser.spec.js
  ● getTargets › allows 'defaults' query

    expect(received).toEqual(expected) // deep equality

    - Expected
    + Received

      Object {
    -   "android": "77.0.0",
    +   "android": "76.0.0",
        "chrome": "49.0.0",
        "edge": "17.0.0",
        "firefox": "68.0.0",
        "ie": "11.0.0",
        "ios": "12.2.0",
    -   "opera": "63.0.0",
    +   "opera": "46.0.0",
        "safari": "5.1.0",
        "samsung": "9.2.0",
      }

const browsers = browserslist(browsersquery, {
path: options.configPath,
mobileToDesktop: true,
});

If I will set mobileToDesktop: false, it passes. I have the same issue on master and it looks that there is a collision in browserNameMap:

  op_mob: "opera",
  opera: "opera",

But I don't understand how it's related to my changes 🤔

@JLHwung
Copy link
Contributor

JLHwung commented Dec 5, 2019

@layershifter The CI error is unrelated to your changes, it comes from recent browserslist 4.8.1 update, I will fix it in another PR.

@existentialism existentialism added the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Dec 6, 2019
@nicolo-ribaudo nicolo-ribaudo merged commit c3388ea into babel:master Jan 10, 2020
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 10, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release Spec: Nullish Coalescing Operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable nullish coalescing by default in @babel/parser
5 participants