Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge env-standalone to babel-standalone #10821

Merged
merged 3 commits into from Jan 11, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Dec 5, 2019

Q                       A
Minor: New Feature? Yes
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? Add more devDependencies to babel-standalone
License MIT

This PR registers env in babel-standalone and copies the plugins in babel-preset-env-standalone to babel-standalone. By doing so babel-standalone will now includes all the functions in env-standalone, and we intend to remove env-standalone on 8.x.

The following size change is produced from CI Artifacts before and CI Artifcats after

Previous Size New Size Change
babel.js 2.4 MB 2.9 MB +20%
babel.min.js 1.2 MB 1.5 MB +25%
babel-preset-env.js 3.0 MB 3.0 MB -
babel-preset-env.min.js 1.3 MB 1.3 MB -

Edit by @nicolo-ribaudo
The previous table should be read as this. These sizes refer to the whole bundle including all the plugins + preset-env.

Previous Total Size New Total Size Change
Not minified 5.4 MB 2.9 MB -46%
Minified 2.5 MB 1.5 MB -40%

@JLHwung JLHwung added pkg: standalone PR: New Feature 🚀 A type of pull request used for our changelog categories labels Dec 5, 2019
@nicolo-ribaudo

This comment has been minimized.

@nicolo-ribaudo nicolo-ribaudo added this to the v7.8.0 milestone Dec 5, 2019
@nicolo-ribaudo nicolo-ribaudo added the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Dec 5, 2019
@@ -110,6 +110,61 @@
).toThrow(/Invalid plugin specified in Babel options: "lolfail"/);
});

describe("env preset", () => {
Copy link
Contributor Author

@JLHwung JLHwung Dec 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The REPL Build is not working. I will investigate it today.
Fixed by rebasing on #10837 : REPL Build

I will rebase again after it gets merged.

@JLHwung JLHwung force-pushed the merge-env-standalone branch 3 times, most recently from 98f15d7 to 19390de Compare December 10, 2019 14:15
@JLHwung
Copy link
Contributor Author

JLHwung commented Jan 11, 2020

@nicolo-ribaudo Note that both nullish-coalescing and optional-chaining are merged to preset-env, this PR is still good to go because those two features are added to both sides. This PR cares only those exclusively available in -standalone.

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 12, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: standalone PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants