Add missing dev dependencies #10847
Merged
Add missing dev dependencies #10847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
the
PR: Internal 🏠
# Conflicts: # yarn.lock
# Conflicts: # packages/babel-register/package.json # yarn.lock
JLHwung
force-pushed
the
declare-dev-dependencies
branch
from
46e39fe
to
461bd2c
Compare
nicolo-ribaudo
approved these changes
Dec 9, 2019
existentialism
approved these changes
Dec 9, 2019
|
@kaicataldo Do you have any clue about where the linting errors might come from? |
|
@nicolo-ribaudo We should map |
package.json
Outdated
| @@ -77,7 +78,9 @@ | |||
| "typescript": "^3.6.3" | |||
| }, | |||
| "resolutions": { | |||
| "@lerna/**/@lerna/collect-updates": "https://github.com/babel/lerna.git#babel-collect-updates" | |||
| "@lerna/**/@lerna/collect-updates": "https://github.com/babel/lerna.git#babel-collect-updates", | |||
| "#todo: remove eslint-scope resolution when babel-eslint 11.0.0-beta.2 is published": "", | |||
There was a problem hiding this comment.
AFAIK, comments aren't supported
There was a problem hiding this comment.
It looks like comment but semantically it is a long sentence key.
JLHwung
force-pushed
the
declare-dev-dependencies
branch
from
bf97d28
to
d48d9ee
Compare
This was referenced Feb 22, 2020
This was referenced Mar 7, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is extracted from a messy working branch on the upcoming Yarn 2 support: https://github.com/JLHwung/babel/commits/standalone-rollup-bundle
The following devDependencies is required since Yarn 2 does not resolve package in
../../node_modules, which is the rootnode_modulesin the project.Note that
eslint-import-resolver-nodewould not bail on these situations since the Node.js module resolution algorithm will resolve all the way up toGLOBAL_FOLDERS.