Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: specify package type [skip-ci] #10849

Merged
merged 1 commit into from Jan 10, 2020
Merged

chore: specify package type [skip-ci] #10849

merged 1 commit into from Jan 10, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Dec 9, 2019

Q                       A
License MIT

Per Node.js ECMAScript Modules Docs, package should include "type" field and be explicit about it.

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Dec 9, 2019
nicolo-ribaudo
nicolo-ribaudo approved these changes Dec 9, 2019
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really looking forward to Yarn 2 when we'll be able to use https://next.yarnpkg.com/features/constraints

@nicolo-ribaudo
Copy link
Member

While this PR doesn't add any new feature, I would prefer to merge it in v7.8.0. Since it changes every package, it will cause every package of the monorepo to be published even if the code is the same.
I think that we should keep patch releases small.

@JLHwung
Copy link
Contributor Author

JLHwung commented Dec 9, 2019

@nicolo-ribaudo I am also going to add exports: false to every package (other than @babel/runtime). I can prepend exports: false to "licence": "MIT" so that we can avoid merge conflicts, though.

@nicolo-ribaudo nicolo-ribaudo added this to the v7.8.0 milestone Dec 9, 2019
@nicolo-ribaudo
Copy link
Member

Since this PR is quite simple, you push the exports changes here as a separate commit and then we'll use "Rebase and merge" instead of "Squash and merge" if you prefer.

@JLHwung JLHwung mentioned this pull request Dec 10, 2019
Closed
@nicolo-ribaudo nicolo-ribaudo added the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Dec 20, 2019
@nicolo-ribaudo
Copy link
Member

I have added the Ready to be Merged label even if there is a single review, since this PR is quite straightforward.

@JLHwung JLHwung merged commit e8dac62 into babel:master Jan 10, 2020
@JLHwung JLHwung deleted the add-type-commonjs branch January 10, 2020 02:40
nicolo-ribaudo added a commit to nicolo-ribaudo/babel that referenced this pull request Jan 13, 2020
@nicolo-ribaudo
Revert "chore: specify package type (babel#10849)"
29a3aaf 
This reverts commit e8dac62.

Fixes installs when using npm <= 3.9.5 (Node.js <= 6.2.2)
nicolo-ribaudo added a commit that referenced this pull request Jan 13, 2020
@nicolo-ribaudo
Revert "chore: specify package type (#10849)" (#11003)
8fce431 
This reverts commit e8dac62.

Fixes installs when using npm <= 3.9.5 (Node.js <= 6.2.2)
@snyk-bot snyk-bot mentioned this pull request Jan 20, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 5, 2020
Open
This was referenced Feb 22, 2020
Open
Open
Merged
This was referenced Mar 7, 2020
Merged
Merged
Merged
Open
Open
This was referenced Mar 14, 2020
Merged
Open
Merged
Merged
Open
Open
This was referenced Mar 21, 2020
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Mar 29, 2020
Open
Open
Open
Open
Open
Open
This was referenced Apr 5, 2020
Open
Open
Open
Open
Open
Open
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 10, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release
Projects
None yet
Milestone
v7.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JLHwung @nicolo-ribaudo