Properly serialize non-json values in parser tests #10858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
area: tests
PR: Internal 🏠
JLHwung
reviewed
Dec 11, 2019
| } | ||
|
|
||
| return result; | ||
| fs.writeFileSync(test.expect.loc, JSON.stringify(ast, serialize, 2)); |
There was a problem hiding this comment.
nit:
consider explicitly specify the ReplaceFunction:
JSON.stringify(ast, (key, value) => serialize(value), 2)
JLHwung
reviewed
Dec 11, 2019
| @@ -221,22 +189,43 @@ function runTest(test, parseFunction) { | |||
| } | |||
| } | |||
|
|
|||
| function serialize(value) { | |||
| function serialize(key, value) { | |||
| if (typeof value === "bigint") { | |||
There was a problem hiding this comment.
Does it imply that the serialization result is dependent on node versions? Because BigInt is not supported in Node.js 6 and 8.
I am surprised that they do not bail.
There was a problem hiding this comment.
When the AST should contain a bigint, null is used instead. For this reason, I made the serialisation dependent on BigInt support.
This is also true before this PR: if you delete packages/babel-parser/test/fixtures/estree/bigInt/basic/output.json and run the tests on node 6, you'll get a different output.
JLHwung
approved these changes
Dec 11, 2019
kaicataldo
approved these changes
Dec 11, 2019
nicolo-ribaudo
added a commit
that referenced
this pull request
Dec 12, 2019
This was referenced Feb 22, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.prototype.toJSONoverride hack and used the mysterious second parameter ofJSON.stringifyPlease disable whitespace diff while reviewing this PR.