New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add computed property support for object Ref #10863
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Bug Fix 🐛
A type of pull request used for our changelog categories
Spec: Object Rest/Spread
labels
Dec 12, 2019
JLHwung
commented
Dec 12, 2019
@@ -0,0 +1,20 @@ | |||
var key, x, y, z; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test case is revised from
Line 1 in 0b3f883
var key, x, y, z; |
nicolo-ribaudo
approved these changes
Dec 18, 2019
...lugin-proposal-object-rest-spread/test/fixtures/object-rest/object-ref-computed-exec/exec.js
Outdated
Show resolved
Hide resolved
...el-plugin-proposal-object-rest-spread/test/fixtures/object-rest/object-ref-computed/input.js
Outdated
Show resolved
Hide resolved
existentialism
approved these changes
Dec 18, 2019
Co-Authored-By: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
...l-plugin-proposal-object-rest-spread/test/fixtures/object-rest/object-ref-computed/output.js
Show resolved
Hide resolved
The failing tests are fixed in master |
This was referenced Feb 22, 2020
This was referenced Mar 7, 2020
This was referenced Mar 14, 2020
github-actions
bot
added
the
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
label
Mar 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
PR: Bug Fix 🐛
A type of pull request used for our changelog categories
Spec: Object Rest/Spread
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we add support for computed properties when generating
objRef
forobject-rest-spread
. In the following exampleHere the
objRef
isobj.prop
, which is the parent path of the rest element...x
. Apparentlyobj.prop
is incorrect because[prop]
is a computed property. This is fixed by addingcomputed
argument when buildingt.memberExpression
forobjRef
.However, the computed properties could be impure: which means we could not evaluate these properties twice. Therefore we refactored the interface of
replaceImpureComputedKeys
and reuse it to cache the computed properties.Note that although this PR only addresses #6341 (comment), #6341 can also be closed after merging this PR because I can not reproduce OP's issue on REPL. (link)