Move coverage to GitHub actions #10898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
the
PR: Internal 🏠
| IS_PUBLISH=true make build-standalone | ||
| # data for a JS file that's several megabytes large is bound to fail. Here, | ||
| # we just run the babel-standalone test separately. | ||
| yarn jest "\-standalone/test" |
There was a problem hiding this comment.
Since this is just for coverage, maybe we can avoid testing standalone here?
There was a problem hiding this comment.
The standalone is only tested on the coverage job in the CI, we have skipped the test on other executors.
There was a problem hiding this comment.
Oh then maybe we should test it separately? I don't really see how it fits in the coverage tests.
There was a problem hiding this comment.
Yeah but standalone will rely on building and installing all the dependencies, I think we can test it here to save redundant machine hours.
JLHwung
force-pushed
the
move-coverage-test-to-github-actions
branch
from
a6b4865
to
6b47be7
Compare
existentialism
approved these changes
Dec 20, 2019
kaicataldo
approved these changes
Dec 20, 2019
This was referenced Feb 22, 2020
This was referenced Mar 7, 2020
This was referenced Mar 14, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENOMEM: not enough memory, stat /home/circleci/babel/packages/just/click/the/rerun/buttonThis PR moves the coverage report job to GitHub Actions. The ENOMEM error should be alleviated because
Merge tips:
Please add
CODECOV_TOKENto theSettings > Secretsafter merging to master. See https://github.com/codecov/codecov-action#usage