Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: separate build-standalone with coverage #10905

Merged
merged 2 commits into from Dec 23, 2019

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Dec 22, 2019

Q                       A
Fixed Issues? Fixes c5cfc83#r36536686
Patch: Bug Fix? Yes
License MIT

This PR fixes regression introduced at c5cfc83 and separates build-standalone with coverage report.

Since babel REPL requires a predictable link of standalone artifacts, we are still relying on CircleCI to build standalone until actions/upload-artifact#27 is resolved.

The make -j flag is also applied to parallelize the build if possible.

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Dec 22, 2019
@JLHwung JLHwung marked this pull request as ready for review December 22, 2019 01:41
@nicolo-ribaudo
Copy link
Member

Repl link to show that this PR works: https://babeljs.io/repl/build/13919

@nicolo-ribaudo nicolo-ribaudo merged commit 83993b0 into babel:master Dec 23, 2019
@nicolo-ribaudo nicolo-ribaudo deleted the fix-artifact-regression branch December 23, 2019 18:03
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Mar 24, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants