Replace custom "findSuggestion" function with "levenary" #10924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: Internal 🏠
kaicataldo
approved these changes
Dec 25, 2019
JLHwung
approved these changes
Dec 25, 2019
tanhauhau
approved these changes
Dec 25, 2019
|
Published levenary@1.1.0 with @JLHwung's PR tanhauhau/levenary#1 |
nicolo-ribaudo
added a commit
that referenced
this pull request
Dec 25, 2019
* Replace custom "findSuggestion" function with "levenary" * Update
nicolo-ribaudo
changed the title
|
This is a breaking change - levenary depends on Node 8. (I realise node 6 (& 8) is EOL - this is still a breaking change in a minor release) |
This was referenced Jan 27, 2020
|
|
|
Thanks for catching this! cc @tanhauhau |
This was referenced Feb 22, 2020
This was referenced Mar 14, 2020
This was referenced Mar 22, 2020
This was referenced Mar 29, 2020
This was referenced Apr 5, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is extracted from #10899. In #10899 I needed to use the
findSuggestionfunction in two different libraries, so I would have had to duplicate that code.Instead of duplicating it, I decided to dig into the universe of fastest levenshtein distance functions on npm to find one with the interface that we actually need.
I initially used
didyoumean2, but then switched tolevenarybecause:I extracted this commit to a separate PR because @JLHwung is going to work on some content which touches similar lines/depends on this package, so we can merge this without waiting for #10899.