Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unused invalidTemplateEscapePosition tokenizer state #10935

Merged
merged 2 commits into from Dec 30, 2019
Merged

refactor: remove unused invalidTemplateEscapePosition tokenizer state #10935

merged 2 commits into from Dec 30, 2019

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Dec 28, 2019

Q                       A
Tests Added + Pass? Yes
License MIT

This PR is based on my observation that this.state.invalidTemplateEscapePosition always point to the start of TemplateElement offset by 1 -- because when this.state.value is null, it must be an escape sequence and invalidTemplateEscapePosition always points to the escape type character immediately following \.

By implementing this invariance we can get rid of the unnecessary invalidTemplateEscapePosition and fix two todo items via removing the code.

@JLHwung JLHwung added PR: Internal 🏠 A type of pull request used for our changelog categories pkg: parser labels Dec 28, 2019
nicolo-ribaudo
nicolo-ribaudo approved these changes Dec 28, 2019
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@JLHwung JLHwung merged commit 2f3f779 into babel:master Dec 30, 2019
@JLHwung JLHwung deleted the remove-unused-tokenizer-state branch December 30, 2019 21:11
@snyk-bot snyk-bot mentioned this pull request Jan 20, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 5, 2020
Open
This was referenced Feb 22, 2020
Open
Open
Merged
This was referenced Mar 7, 2020
Merged
Merged
Open
Open
This was referenced Mar 14, 2020
Merged
Open
Merged
Merged
Open
Open
Open
This was referenced Mar 22, 2020
Open
Open
Open
Open
Open
Open
This was referenced Mar 27, 2020
Open
Open
Open
Open
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Mar 31, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JLHwung @existentialism @nicolo-ribaudo