Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused parser methods #10942

Merged
merged 2 commits into from Dec 30, 2019
Merged

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Dec 29, 2019

Q                       A
Tests Added + Pass? Yes
License MIT

Remove two unused methods.

I found these two from the coverage report: https://codecov.io/gh/babel/babel/src/b91720c1ccbfc066cbc6af7e3db6114acefac17a/packages/babel-parser/src/parser/util.js

And the GitHub Code search
eatRelational: https://github.com/babel/babel/search?q=eatRelational&unscoped_q=eatRelational
isStrictBody: https://github.com/babel/babel/search?q=isStrictBody&unscoped_q=isStrictBody

@JLHwung JLHwung added PR: Internal 🏠 A type of pull request used for our changelog categories pkg: parser labels Dec 29, 2019
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😁

@JLHwung JLHwung merged commit 197a8da into babel:master Dec 30, 2019
@JLHwung JLHwung deleted the remove-unused-parser-methods branch December 30, 2019 21:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants