Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check await when parsing AsyncArrowBindingIdentifier #10953

Merged
merged 1 commit into from Jan 3, 2020
Merged

fix: check await when parsing AsyncArrowBindingIdentifier #10953

merged 1 commit into from Jan 3, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jan 2, 2020

Q                       A
Fixed Issues? When parsing AsyncArrowBindingIdentifier, we should check if it is await.
Patch: Bug Fix? Yes
Tests Added + Pass? Yes
License MIT

When parsing

async [no LineTerminator here] AsyncArrowBindingIdentifier[?Yield] [no LineTerminator here] =>
  AsyncConciseBody[?In],

the await check is missing so babel does not throw on async await => {}, this PR adds the context manipulation step also used in parseParenAndDistinguishExpression.

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: parser labels Jan 2, 2020
@nicolo-ribaudo nicolo-ribaudo added PR: Spec Compliance 👓 A type of pull request used for our changelog categories and removed PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Jan 2, 2020
@nicolo-ribaudo nicolo-ribaudo merged commit a283537 into babel:master Jan 3, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the fix-async-arrow-binding-identifier branch January 3, 2020 22:08
@snyk-bot snyk-bot mentioned this pull request Jan 20, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 5, 2020
Open
This was referenced Feb 22, 2020
Open
Open
Merged
This was referenced Mar 7, 2020
Merged
Merged
Open
Open
This was referenced Mar 14, 2020
Merged
Open
Merged
Merged
Open
Open
Open
This was referenced Mar 22, 2020
Open
Open
Open
Open
Open
This was referenced Mar 27, 2020
Open
Open
Open
Open
Open
Open
Open
This was referenced Apr 3, 2020
Open
Open
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 4, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Spec Compliance 👓 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JLHwung @nicolo-ribaudo @kaicataldo