Update Test262, Flow and TS parser tests #10976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolo-ribaudo
commented
Jan 10, 2020
nicolo-ribaudo
commented
| Q | A |
|---|---|
| Tests Added + Pass? | Yes |
| License | MIT |
nicolo-ribaudo
added
area: tests
PR: Internal 🏠
JLHwung
reviewed
Jan 10, 2020
| @@ -58,6 +59,7 @@ augmentedTypesEnum2.ts | |||
| augmentedTypesFunction.ts | |||
| augmentedTypesInterface.ts | |||
| augmentedTypesVar.ts | |||
| awaitInClassInAsyncFunction.ts | |||
There was a problem hiding this comment.
Hasn't this case been fixed in master?
There was a problem hiding this comment.
This PR is based on c3388ea, which was master 20 mins ago 🤔
There was a problem hiding this comment.
Oh I just realized that parseDiagnostics is incomplete. And this case is considered a valid program. I will see if I can shrink the false negatives in the whitelist tomorrow.
nicolo-ribaudo
force-pushed
the
update-3p-tests
branch
from
c8d631c
to
34caf2d
Compare
JLHwung
approved these changes
Jan 10, 2020
This was referenced Feb 22, 2020
This was referenced Mar 7, 2020
This was referenced Mar 14, 2020
This was referenced Mar 22, 2020
This was referenced Mar 26, 2020
This was referenced Apr 3, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.