Disallow private name in object elements and TS type elements #10980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Spec Compliance 👓
JLHwung
force-pushed
the
fix-private-name-in-destructuring
branch
from
77aabfd
to
3991864
Compare
JLHwung
changed the title
JLHwung
commented
Jan 11, 2020
JLHwung
changed the title
nicolo-ribaudo
approved these changes
Jan 11, 2020
Co-Authored-By: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
JLHwung
force-pushed
the
fix-private-name-in-destructuring
branch
from
43907aa
to
e7619ce
Compare
Co-Authored-By: Brian Ng <bng412@gmail.com>
This was referenced Feb 22, 2020
This was referenced Mar 7, 2020
This was referenced Mar 14, 2020
This was referenced Mar 22, 2020
This was referenced Mar 29, 2020
This was referenced Apr 5, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we add a new boolean argument
isPrivateNameAllowedforparseMaybePrivateNameso that we can throw if private name is not allowed in the current grammar context.This PR also clears the test262 whitelist, which marks the milestone where babel-parser is now 100% test262 compliant.