Re-generate preset-env fixtures #11016

nicolo-ribaudo · 2020-01-16T01:09:24Z

Q	A
Tests Added + Pass?	Yes
Documentation PR Link
Any Dependency Changes?
License	MIT

This PR should only re-order the logged plugins. I don't know why GitHub shows more created lines than deleted, but locally the match:

➜ git diff --numstat HEAD^..HEAD

10	10	packages/babel-preset-env/test/fixtures/corejs2/usage-browserslist-config-ignore/stdout.txt
10	10	packages/babel-preset-env/test/fixtures/corejs3/usage-browserslist-config-ignore/stdout.txt
25	25	packages/babel-preset-env/test/fixtures/debug/browserslists-android-3/stdout.txt
24	24	packages/babel-preset-env/test/fixtures/debug/browserslists-defaults-not-ie/stdout.txt
24	24	packages/babel-preset-env/test/fixtures/debug/browserslists-defaults/stdout.txt
7	7	packages/babel-preset-env/test/fixtures/debug/browserslists-last-2-versions-not-ie/stdout.txt
25	25	packages/babel-preset-env/test/fixtures/debug/corejs-without-usebuiltins/stdout.txt
24	24	packages/babel-preset-env/test/fixtures/debug/entry-corejs2-android/stdout.txt
15	15	packages/babel-preset-env/test/fixtures/debug/entry-corejs2-electron/stdout.txt
25	25	packages/babel-preset-env/test/fixtures/debug/entry-corejs2-force-all-transforms/stdout.txt
9	9	packages/babel-preset-env/test/fixtures/debug/entry-corejs2-no-import/stdout.txt
2	2	packages/babel-preset-env/test/fixtures/debug/entry-corejs2-proposals-chrome-71/stdout.txt
25	25	packages/babel-preset-env/test/fixtures/debug/entry-corejs2-proposals/stdout.txt
2	2	packages/babel-preset-env/test/fixtures/debug/entry-corejs2-shippedProposals-chrome-71/stdout.txt
25	25	packages/babel-preset-env/test/fixtures/debug/entry-corejs2-shippedProposals/stdout.txt
24	24	packages/babel-preset-env/test/fixtures/debug/entry-corejs2-specific-targets/stdout.txt
25	25	packages/babel-preset-env/test/fixtures/debug/entry-corejs2-versions-decimals/stdout.txt
24	24	packages/babel-preset-env/test/fixtures/debug/entry-corejs2-versions-strings/stdout.txt
24	24	packages/babel-preset-env/test/fixtures/debug/entry-corejs2/stdout.txt
2	2	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-all-chrome-71/stdout.txt
25	25	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-all/stdout.txt
24	24	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-android/stdout.txt
25	25	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-babel-polyfill/stdout.txt
15	15	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-electron/stdout.txt
2	2	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-es-chrome-71/stdout.txt
2	2	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-es-proposals-chrome-71/stdout.txt
25	25	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-es-proposals/stdout.txt
25	25	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-es/stdout.txt
25	25	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-force-all-transforms/stdout.txt
9	9	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-no-import/stdout.txt
2	2	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-proposals-chrome-71/stdout.txt
25	25	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-proposals/stdout.txt
2	2	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-runtime-only-chrome-71/stdout.txt
2	2	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-runtime-only/stdout.txt
2	2	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-specific-entries-chrome-71/stdout.txt
25	25	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-specific-entries/stdout.txt
24	24	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-specific-targets/stdout.txt
2	2	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-stable-chrome-71/stdout.txt
3	3	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-stable-samsung-8.2/stdout.txt
25	25	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-stable/stdout.txt
2	2	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-stage-chrome-71/stdout.txt
25	25	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-stage/stdout.txt
25	25	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-versions-decimals/stdout.txt
24	24	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-versions-strings-minor-3.0/stdout.txt
24	24	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-versions-strings-minor-3.1/stdout.txt
24	24	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-versions-strings/stdout.txt
2	2	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-web-chrome-71/stdout.txt
25	25	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-web/stdout.txt
24	24	packages/babel-preset-env/test/fixtures/debug/entry-corejs3/stdout.txt
9	9	packages/babel-preset-env/test/fixtures/debug/entry-no-corejs-no-import/stdout.txt
25	25	packages/babel-preset-env/test/fixtures/debug/entry-no-corejs-shippedProposals/stdout.txt
25	25	packages/babel-preset-env/test/fixtures/debug/entry-no-corejs-uglify/stdout.txt
24	24	packages/babel-preset-env/test/fixtures/debug/entry-no-corejs/stdout.txt
8	8	packages/babel-preset-env/test/fixtures/debug/plugins-only/stdout.txt
24	24	packages/babel-preset-env/test/fixtures/debug/usage-corejs2-1/stdout.txt
24	24	packages/babel-preset-env/test/fixtures/debug/usage-corejs2-2/stdout.txt
2	2	packages/babel-preset-env/test/fixtures/debug/usage-corejs2-chrome-71-1/stdout.txt
2	2	packages/babel-preset-env/test/fixtures/debug/usage-corejs2-chrome-71-2/stdout.txt
24	24	packages/babel-preset-env/test/fixtures/debug/usage-corejs2-none-1/stdout.txt
24	24	packages/babel-preset-env/test/fixtures/debug/usage-corejs2-none-2/stdout.txt
24	24	packages/babel-preset-env/test/fixtures/debug/usage-corejs2-proposals-1/stdout.txt
24	24	packages/babel-preset-env/test/fixtures/debug/usage-corejs2-proposals-2/stdout.txt
2	2	packages/babel-preset-env/test/fixtures/debug/usage-corejs2-proposals-chrome-71-1/stdout.txt
2	2	packages/babel-preset-env/test/fixtures/debug/usage-corejs2-proposals-chrome-71-2/stdout.txt
24	24	packages/babel-preset-env/test/fixtures/debug/usage-corejs2-shippedProposals-1/stdout.txt
24	24	packages/babel-preset-env/test/fixtures/debug/usage-corejs2-shippedProposals-2/stdout.txt
4	4	packages/babel-preset-env/test/fixtures/debug/usage-corejs2-with-import/stdout.txt
24	24	packages/babel-preset-env/test/fixtures/debug/usage-corejs3-1/stdout.txt
24	24	packages/babel-preset-env/test/fixtures/debug/usage-corejs3-2/stdout.txt
2	2	packages/babel-preset-env/test/fixtures/debug/usage-corejs3-chrome-71-1/stdout.txt
2	2	packages/babel-preset-env/test/fixtures/debug/usage-corejs3-chrome-71-2/stdout.txt
24	24	packages/babel-preset-env/test/fixtures/debug/usage-corejs3-none-1/stdout.txt
24	24	packages/babel-preset-env/test/fixtures/debug/usage-corejs3-none-2/stdout.txt
24	24	packages/babel-preset-env/test/fixtures/debug/usage-corejs3-proposals-1/stdout.txt
24	24	packages/babel-preset-env/test/fixtures/debug/usage-corejs3-proposals-2/stdout.txt
2	2	packages/babel-preset-env/test/fixtures/debug/usage-corejs3-proposals-chrome-71-1/stdout.txt
2	2	packages/babel-preset-env/test/fixtures/debug/usage-corejs3-proposals-chrome-71-2/stdout.txt
24	24	packages/babel-preset-env/test/fixtures/debug/usage-corejs3-shippedProposals-1/stdout.txt
24	24	packages/babel-preset-env/test/fixtures/debug/usage-corejs3-shippedProposals-2/stdout.txt
24	24	packages/babel-preset-env/test/fixtures/debug/usage-corejs3-versions-strings-minor-3.0-1/stdout.txt
24	24	packages/babel-preset-env/test/fixtures/debug/usage-corejs3-versions-strings-minor-3.0-2/stdout.txt
24	24	packages/babel-preset-env/test/fixtures/debug/usage-corejs3-versions-strings-minor-3.1-1/stdout.txt
24	24	packages/babel-preset-env/test/fixtures/debug/usage-corejs3-versions-strings-minor-3.1-2/stdout.txt
4	4	packages/babel-preset-env/test/fixtures/debug/usage-corejs3-with-import/stdout.txt
24	24	packages/babel-preset-env/test/fixtures/debug/usage-no-corejs-1/stdout.txt
24	24	packages/babel-preset-env/test/fixtures/debug/usage-no-corejs-2/stdout.txt
24	24	packages/babel-preset-env/test/fixtures/debug/usage-no-corejs-none-1/stdout.txt
24	24	packages/babel-preset-env/test/fixtures/debug/usage-no-corejs-none-2/stdout.txt
9	9	packages/babel-preset-env/test/fixtures/preset-options/safari-10_3-block-scoped/stdout.txt
15	10	packages/babel-preset-env/test/fixtures/sanity/block-scoping-for-of/output.js

nicolo-ribaudo · 2020-01-16T01:12:28Z

Oh nevermind, packages/babel-preset-env/test/fixtures/sanity/block-scoping-for-of/output.js changed. It seems caused by a different plugin ordering, introduced because of https://github.com/babel/babel/pull/10811/files#diff-a22feee84e9f4b2f880aabb7595a1c87 which reordered the plugins.

nicolo-ribaudo · 2020-01-16T01:27:54Z

This is not safe, I'll investigate

nicolo-ribaudo · 2020-01-16T01:44:15Z

Ok now it looks ok:

201	201	packages/babel-compat-data/data/plugins.json
92	68	packages/babel-compat-data/scripts/data/plugin-features.js
10	10	packages/babel-preset-env/test/fixtures/corejs2/usage-browserslist-config-ignore/stdout.txt
10	10	packages/babel-preset-env/test/fixtures/corejs3/usage-browserslist-config-ignore/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/browserslists-android-3/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/browserslists-defaults-not-ie/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/browserslists-defaults/stdout.txt
8	8	packages/babel-preset-env/test/fixtures/debug/browserslists-last-2-versions-not-ie/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/corejs-without-usebuiltins/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/entry-corejs2-android/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/entry-corejs2-electron/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/entry-corejs2-force-all-transforms/stdout.txt
10	10	packages/babel-preset-env/test/fixtures/debug/entry-corejs2-no-import/stdout.txt
4	4	packages/babel-preset-env/test/fixtures/debug/entry-corejs2-proposals-chrome-71/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/entry-corejs2-proposals/stdout.txt
4	4	packages/babel-preset-env/test/fixtures/debug/entry-corejs2-shippedProposals-chrome-71/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/entry-corejs2-shippedProposals/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/entry-corejs2-specific-targets/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/entry-corejs2-versions-decimals/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/entry-corejs2-versions-strings/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/entry-corejs2/stdout.txt
4	4	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-all-chrome-71/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-all/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-android/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-babel-polyfill/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-electron/stdout.txt
4	4	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-es-chrome-71/stdout.txt
4	4	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-es-proposals-chrome-71/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-es-proposals/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-es/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-force-all-transforms/stdout.txt
10	10	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-no-import/stdout.txt
4	4	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-proposals-chrome-71/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-proposals/stdout.txt
4	4	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-runtime-only-chrome-71/stdout.txt
4	4	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-runtime-only/stdout.txt
4	4	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-specific-entries-chrome-71/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-specific-entries/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-specific-targets/stdout.txt
4	4	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-stable-chrome-71/stdout.txt
4	4	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-stable-samsung-8.2/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-stable/stdout.txt
4	4	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-stage-chrome-71/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-stage/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-versions-decimals/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-versions-strings-minor-3.0/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-versions-strings-minor-3.1/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-versions-strings/stdout.txt
4	4	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-web-chrome-71/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/entry-corejs3-web/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/entry-corejs3/stdout.txt
10	10	packages/babel-preset-env/test/fixtures/debug/entry-no-corejs-no-import/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/entry-no-corejs-shippedProposals/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/entry-no-corejs-uglify/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/entry-no-corejs/stdout.txt
9	9	packages/babel-preset-env/test/fixtures/debug/plugins-only/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/usage-corejs2-1/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/usage-corejs2-2/stdout.txt
4	4	packages/babel-preset-env/test/fixtures/debug/usage-corejs2-chrome-71-1/stdout.txt
4	4	packages/babel-preset-env/test/fixtures/debug/usage-corejs2-chrome-71-2/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/usage-corejs2-none-1/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/usage-corejs2-none-2/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/usage-corejs2-proposals-1/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/usage-corejs2-proposals-2/stdout.txt
4	4	packages/babel-preset-env/test/fixtures/debug/usage-corejs2-proposals-chrome-71-1/stdout.txt
4	4	packages/babel-preset-env/test/fixtures/debug/usage-corejs2-proposals-chrome-71-2/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/usage-corejs2-shippedProposals-1/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/usage-corejs2-shippedProposals-2/stdout.txt
5	5	packages/babel-preset-env/test/fixtures/debug/usage-corejs2-with-import/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/usage-corejs3-1/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/usage-corejs3-2/stdout.txt
4	4	packages/babel-preset-env/test/fixtures/debug/usage-corejs3-chrome-71-1/stdout.txt
4	4	packages/babel-preset-env/test/fixtures/debug/usage-corejs3-chrome-71-2/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/usage-corejs3-none-1/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/usage-corejs3-none-2/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/usage-corejs3-proposals-1/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/usage-corejs3-proposals-2/stdout.txt
4	4	packages/babel-preset-env/test/fixtures/debug/usage-corejs3-proposals-chrome-71-1/stdout.txt
4	4	packages/babel-preset-env/test/fixtures/debug/usage-corejs3-proposals-chrome-71-2/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/usage-corejs3-shippedProposals-1/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/usage-corejs3-shippedProposals-2/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/usage-corejs3-versions-strings-minor-3.0-1/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/usage-corejs3-versions-strings-minor-3.0-2/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/usage-corejs3-versions-strings-minor-3.1-1/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/usage-corejs3-versions-strings-minor-3.1-2/stdout.txt
5	5	packages/babel-preset-env/test/fixtures/debug/usage-corejs3-with-import/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/usage-no-corejs-1/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/usage-no-corejs-2/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/usage-no-corejs-none-1/stdout.txt
11	11	packages/babel-preset-env/test/fixtures/debug/usage-no-corejs-none-2/stdout.txt
10	10	packages/babel-preset-env/test/fixtures/preset-options/safari-10_3-block-scoped/stdout.txt

Ref: #8138, #7586

JLHwung · 2020-01-16T01:53:13Z

packages/babel-compat-data/scripts/data/plugin-features.js

+  "proposal-async-generator-functions": "Asynchronous Iterators",
+  "proposal-object-rest-spread": "object rest/spread properties",
+
+  // We want to apply this prior to unicode regex so that "." and "u"


I don't think the order of regex-related plugins still matters since they are essentially feature flags now, the regexpu-core should only run once for every applicable regex.

JLHwung · 2020-01-16T01:56:59Z

packages/babel-compat-data/scripts/data/plugin-features.js

-  "proposal-optional-catch-binding": "optional catch binding",
-  "proposal-optional-chaining": "optional chaining operator (?.)",
-  "proposal-unicode-property-regex": "RegExp Unicode Property Escapes",
+const es5 = {


Would be good to add a comment here if the key order will impact the plugin execution order of preset-env.

existentialism

I coulda swore I had a comment about keeping order of the data, but I guess not ¯_(ツ)_/¯

nicolo-ribaudo force-pushed the update-env-fixtures-ordering branch from bfa4f6d to a6c8c64 Compare January 16, 2020 01:31

nicolo-ribaudo added 2 commits January 16, 2020 02:42

Fix plugin ordering in preset-env

80a99c5

Update stdout fixtures

0efeb52

nicolo-ribaudo force-pushed the update-env-fixtures-ordering branch from a6c8c64 to 0efeb52 Compare January 16, 2020 01:43

nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories PR: Fixes failing main pkg: preset-env i: regression labels Jan 16, 2020

JLHwung reviewed Jan 16, 2020

View reviewed changes

Comments [skip ci]

1edd329

JLHwung approved these changes Jan 16, 2020

View reviewed changes

existentialism approved these changes Jan 16, 2020

View reviewed changes

JLHwung merged commit 3daab41 into babel:master Jan 16, 2020

snyk-bot mentioned this pull request Feb 22, 2020

[Snyk] Upgrade @babel/runtime from 7.4.4 to 7.8.4 mboocannon/msgraph-sdk-javascript#5

Open

This was referenced Feb 24, 2020

chore(deps-dev): bump @babel/preset-env from 7.7.7 to 7.8.4 AKASHAorg/akasha-core#391

Closed

chore(deps-dev): bump @babel/core from 7.7.7 to 7.8.4 AKASHAorg/akasha-core#390

Closed

This was referenced Feb 28, 2020

[Snyk] Upgrade @babel/runtime from 7.2.0 to 7.8.4 mieweb/sqladmin#5

Open

[Snyk] Upgrade: @babel/cli, @babel/core, @babel/node, @babel/plugin-transform-runtime, @babel/preset-env, @babel/register, @babel/runtime VonSwirl/ES6-boilerplate-webapp#33

Merged

snyk-bot mentioned this pull request Mar 14, 2020

[Snyk] Upgrade @babel/runtime from 7.6.3 to 7.8.7 meteorengineer/meteor-graphql#16

Merged

github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 17, 2020

github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Re-generate preset-env fixtures #11016

Re-generate preset-env fixtures #11016

nicolo-ribaudo commented Jan 16, 2020

nicolo-ribaudo commented Jan 16, 2020

nicolo-ribaudo commented Jan 16, 2020

nicolo-ribaudo commented Jan 16, 2020 •

edited

JLHwung Jan 16, 2020

JLHwung Jan 16, 2020

existentialism left a comment

Re-generate preset-env fixtures #11016

Re-generate preset-env fixtures #11016

Conversation

nicolo-ribaudo commented Jan 16, 2020

nicolo-ribaudo commented Jan 16, 2020

nicolo-ribaudo commented Jan 16, 2020

nicolo-ribaudo commented Jan 16, 2020 • edited

JLHwung Jan 16, 2020

Choose a reason for hiding this comment

JLHwung Jan 16, 2020

Choose a reason for hiding this comment

existentialism left a comment

Choose a reason for hiding this comment

nicolo-ribaudo commented Jan 16, 2020 •

edited