chore: replace yarn-upgrade by bump-babel-dependencies in vuejs e2e tests #11021
Conversation
JLHwung
commented
Jan 16, 2020
JLHwung
commented
| Q | A |
|---|---|
| Fixed Issues? | Fix failing vue-cli e2e tests |
| License | MIT |
JLHwung
force-pushed
the
pin-yarn-version-in-vue-cli-tests
branch
2 times, most recently
from
4045273
to
9778007
Compare
JLHwung
force-pushed
the
pin-yarn-version-in-vue-cli-tests
branch
from
9778007
to
2490d5d
Compare
JLHwung
added
area: tests
PR: Fixes failing main
PR: Internal 🏠
| @@ -0,0 +1,29 @@ | |||
| const fs = require("fs"); | |||
There was a problem hiding this comment.
@nicolo-ribaudo WDYT replacing yarn-upgrade by this snippet in e2e-create-react-app 🤷♂️
JLHwung
changed the title
| function bumpBabelDependency(dependencies) { | ||
| for (const dep of Object.keys(dependencies)) { | ||
| if (dep.startsWith("@babel/")) { | ||
| dependencies[dep] = "latest"; |
There was a problem hiding this comment.
Technically if a downstream project specifies latest for @babel/ in the package.json, this approach will not work at all because yarn will then lock latest to old versions. But practically this scenario should never happen.
|
@nicolo-ribaudo The first error is due to yarnpkg/yarn#7797, instead of manually updating every babel plugins, I fall back to Yarn 1.18, but then there is a second error which never happens on Yarn >= 1.19. I'd rather not to die on this hill and come up with |
|
Ok then, let's use that script everywhere |
github-actions
bot
added
the
outdated
