Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that generated compat-data is up to date on CI #11024

Merged
merged 1 commit into from Jan 20, 2020

Conversation

nicolo-ribaudo
Copy link
Member

Q                       A
Tests Added + Pass? Yes
License MIT

This will prevent cases like 6363b59: the file used to generate the data was updated but the data itself wasn't, so we didn't notice the regression in the PR which updated the compat-table mappings.

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Jan 16, 2020
@@ -306,7 +306,7 @@ const generateData = (environments, features) => {
"The newly generated plugin/built-in data does not match the current " +
"files. Re-run `make build-compat-data`."
);
process.exit(1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert this commit? I realize that this function is in a forEach callback.

@nicolo-ribaudo nicolo-ribaudo merged commit 2b23c28 into babel:master Jan 20, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the check-compat-data branch January 20, 2020 00:42
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 20, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: tests outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants