Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update compat table #11039

Merged
merged 5 commits into from Jan 27, 2020
Merged

Update compat table #11039

merged 5 commits into from Jan 27, 2020

Conversation

nicolo-ribaudo
Copy link
Member

Q                       A
Patch: Bug Fix? Y
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Our data never actually included "safari": "tp", so we never found the bug in the build script before 😅

@nicolo-ribaudo nicolo-ribaudo added PR: Internal 🏠 A type of pull request used for our changelog categories pkg: preset-env labels Jan 21, 2020
nicolo-ribaudo
nicolo-ribaudo commented Jan 21, 2020
View reviewed changes
packages/babel-compat-data/data/plugins.json Outdated
@@ -275,7 +285,7 @@
},
"transform-block-scoping": {
"chrome": "49",
"edge": "14",
"edge": "79",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should check why this changed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing compat-table/compat-table#1569?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That commit didn't change the data files 🤔

cc @chicoxyzzy

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use essentially the same code as compat-table's HTML generation to interpolate versions via environments.json. As I said, was just a guess... I'll try to dig a bit further when I get home.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's because of equals field. Looks correct to me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, edge14 still supports let/const. Maybe it's bug in our script?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://kangax.github.io/compat-table/es6/ has the same bug. Any version of Edge before 79 is marked as not supporting let/const.

@existentialism
Copy link
Member

Our data never actually included "safari": "tp"

You mean recently? We've definitely had tp in the past.

@nicolo-ribaudo
Copy link
Member Author

nicolo-ribaudo commented Jan 21, 2020 •
edited

Yeah, I mean "after that line in the script was changed". unreleasedLabelForEnv is a string, so I don't see how returning it could have worked were we expect an object with version and semver properties.

@nicolo-ribaudo nicolo-ribaudo changed the title Update compat table [WIP] Update compat table Jan 21, 2020
nicolo-ribaudo
nicolo-ribaudo commented Jan 21, 2020
View reviewed changes
packages/babel-compat-data/data/plugins.json Outdated
@@ -253,7 +263,7 @@
},
"transform-parameters": {
"chrome": "49",
"edge": "18",
"edge": "15",

This comment was marked as resolved.

Sign in to view

@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Jan 21, 2020
Closed
@nicolo-ribaudo nicolo-ribaudo changed the title [WIP] Update compat table Update compat table Jan 24, 2020
@nicolo-ribaudo
Copy link
Member Author

I have fixed the compat-table bug. This is ready for review!

@nicolo-ribaudo nicolo-ribaudo merged commit eae6211 into babel:master Jan 27, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the update-compat-table branch January 27, 2020 21:23
rajasekarm pushed a commit to rajasekarm/babel that referenced this pull request Feb 17, 2020
@nicolo-ribaudo @rajasekarm
Update compat table (babel#11039)
44b90a5 
* Fix compat-data build script

* Update compat table

* Update mappings for transform-parameters

compat-table/compat-table#1570

* Update unrelated fixture

* Update
@snyk-bot snyk-bot mentioned this pull request Feb 22, 2020
Open
This was referenced Feb 24, 2020
Closed
Closed
This was referenced Feb 28, 2020
Open
Merged
This was referenced Mar 7, 2020
Merged
Merged
This was referenced Mar 25, 2020
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Apr 2, 2020
Open
Open
Open
Open
Open
Open
This was referenced Apr 9, 2020
Open
Open
Open
Open
Open
Open
Open
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 28, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chicoxyzzy chicoxyzzy chicoxyzzy left review comments

@existentialism existentialism existentialism approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: preset-env PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nicolo-ribaudo @existentialism @chicoxyzzy @kaicataldo