Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@babel/cli] Copy ignored files by default #11063

Merged
merged 1 commit into from Jan 30, 2020

Conversation

nicolo-ribaudo
Copy link
Member

Q                       A
Fixed Issues? Fixes #11052
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This commit restores the pre-7.8.0 behavior of the --copy-files option, by making --copy-ignored default to true when --copy-files is enabled.

@serhalp Could you check if the --copy-files tests in https://github.com/nicolo-ribaudo/babel/tree/regression-7.8-cli/packages/babel-cli/test/fixtures/babel match your expectations?

@STRML I didn't take a look at the other bug you mentioned in #11052

This commit restores the pre-7.8.0 behavior of the --copy-files option, by making
--copy-ignored default to true when --copy-files is enabled.
@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories i: regression PR: Needs Docs labels Jan 28, 2020
@nicolo-ribaudo nicolo-ribaudo added this to the v7.8.4 milestone Jan 28, 2020
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The negative flag feels a little strange to me, but I don't have a better suggestion 🤷‍♂️

@nicolo-ribaudo
Copy link
Member Author

@kaicataldo We also have other --no- options. Also, I think that it's quite standard for boolean flags that default to true, since commander automatically handles the --no- prefix as such.

@STRML
Copy link
Contributor

STRML commented Jan 29, 2020

Great. We can fix #11052 (comment) separately. 👍

Copy link
Member

@rajasekarm rajasekarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolo-ribaudo nicolo-ribaudo merged commit 92c6807 into babel:master Jan 30, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the regression-7.8-cli branch January 30, 2020 12:01
rajasekarm pushed a commit to rajasekarm/babel that referenced this pull request Feb 17, 2020
This commit restores the pre-7.8.0 behavior of the --copy-files option, by making
--copy-ignored default to true when --copy-files is enabled.
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 1, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories PR: Needs Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v7.8.0 introduces a non-backwards-compatible change
5 participants