New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@babel/cli] Copy ignored files by default #11063
[@babel/cli] Copy ignored files by default #11063
Conversation
This commit restores the pre-7.8.0 behavior of the --copy-files option, by making --copy-ignored default to true when --copy-files is enabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The negative flag feels a little strange to me, but I don't have a better suggestion 🤷♂️
@kaicataldo We also have other |
Great. We can fix #11052 (comment) separately. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This commit restores the pre-7.8.0 behavior of the --copy-files option, by making --copy-ignored default to true when --copy-files is enabled.
This commit restores the pre-7.8.0 behavior of the
--copy-files
option, by making--copy-ignored
default to true when--copy-files
is enabled.@serhalp Could you check if the
--copy-files
tests in https://github.com/nicolo-ribaudo/babel/tree/regression-7.8-cli/packages/babel-cli/test/fixtures/babel match your expectations?@STRML I didn't take a look at the other bug you mentioned in #11052