Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean babel-eslint-*/**/lib #11070

Merged
merged 1 commit into from Jan 31, 2020

Conversation

kaicataldo
Copy link
Member

Q                       A
Fixed Issues?
Patch: Bug Fix? 👍
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

I was having trouble running make lint locally because I had an old babel-eslint-config-internal/lib that was being used. Since the main file in question isn't in src, it wasn't getting recompiled and I was therefore using the old compiled output.

I don't think we need to avoid cleaning the ESLint packages now that they're all using src if they're compiledand are not insrc` if not.

package.json Outdated Show resolved Hide resolved
@kaicataldo kaicataldo changed the title Clean babel-eslint-*/**/lib Use babel-eslint-* packages for linting monorepo Jan 30, 2020
@kaicataldo
Copy link
Member Author

Once we figure this out I'll start working on ensuring ESLint's core rules work!

@kaicataldo kaicataldo changed the title Use babel-eslint-* packages for linting monorepo Clean babel-eslint-*/**/lib Jan 30, 2020
@kaicataldo
Copy link
Member Author

kaicataldo commented Jan 30, 2020

Okay, so I've tried a number of different things to try to get the local packages hoisted, including using Yarn workspaces and trying to install from the package directory itself. I think I'm going to give up on this and just wait until we publish these packages.

We should still merge this though, since babel-eslint-config-internal does not generate a lib/index.js file any more! This is ready for review.

@@ -7,7 +7,7 @@
"license": "MIT",
"private": true,
"repository": "https://github.com/babel/babel/tree/master/eslint/babel-eslint-config-internal",
"main": "lib/index.js",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file doesn't exist because we don't compile this file.

@kaicataldo kaicataldo added the PR: Internal 🏠 A type of pull request used for our changelog categories label Jan 30, 2020
@nicolo-ribaudo
Copy link
Member

Okay, so I've tried a number of different things to try to get the local packages hoisted, including using Yarn workspaces and trying to install from the package directory itself. I think I'm going to give up on this and just wait until we publish these packages.

I'll try to make it work tomorrow.

@nicolo-ribaudo nicolo-ribaudo self-assigned this Jan 30, 2020
@nicolo-ribaudo nicolo-ribaudo merged commit f987821 into babel:master Jan 31, 2020
rajasekarm pushed a commit to rajasekarm/babel that referenced this pull request Feb 17, 2020
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 2, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: eslint outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants