New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean babel-eslint-*/**/lib #11070
Clean babel-eslint-*/**/lib #11070
Conversation
Once we figure this out I'll start working on ensuring ESLint's core rules work! |
3f32c4c
to
99f7144
Compare
Okay, so I've tried a number of different things to try to get the local packages hoisted, including using Yarn workspaces and trying to install from the package directory itself. I think I'm going to give up on this and just wait until we publish these packages. We should still merge this though, since |
@@ -7,7 +7,7 @@ | |||
"license": "MIT", | |||
"private": true, | |||
"repository": "https://github.com/babel/babel/tree/master/eslint/babel-eslint-config-internal", | |||
"main": "lib/index.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file doesn't exist because we don't compile this file.
I'll try to make it work tomorrow. |
I was having trouble running
make lint
locally because I had an oldbabel-eslint-config-internal/lib
that was being used. Since the main file in question isn't insrc
, it wasn't getting recompiled and I was therefore using the old compiled output.I don't think we need to avoid cleaning the ESLint packages now that they're all using
src
if they're compiledand are not in
src` if not.