Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stage presets from the monorepo #11101

Merged
merged 1 commit into from Feb 6, 2020

Conversation

nicolo-ribaudo
Copy link
Member

Q                       A
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

babel/babel-archive already includes the last working version of these presets (v7.0.0-beta.52), and they have been throwing since 7.0.0

babel/babel-archive already includes the last working version of these presets (v7.0.0-beta.52), and they have been throwing since 7.0.0
@nicolo-ribaudo nicolo-ribaudo added the PR: Internal 🏠 A type of pull request used for our changelog categories label Feb 6, 2020
Copy link
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! awesome, finally 😄

I forget why we didn't remove it earlier, was it for the repl?

@nicolo-ribaudo
Copy link
Member Author

Probably yes, but now they are hardcoded in @babel/standalone (sigh).
Maybe we could remove them from @babel/standalone in Babel 8 and hard-code it in babel/website.

@hzoo
Copy link
Member

hzoo commented Feb 6, 2020

Oh right! We'll we aren't expecting anyone to be using any stage presets anymore for a long time now so we could remove it there too. It's only for convenience in the repl and that we haven't made the UI change there?

@nicolo-ribaudo
Copy link
Member Author

It's only for convenience in the repl and that we haven't made the UI change there?

Yeah, exactly.

@nicolo-ribaudo nicolo-ribaudo merged commit 5e58903 into babel:master Feb 6, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the remove-stage-presets branch February 6, 2020 17:03
@nicolo-ribaudo
Copy link
Member Author

(The build failure is unrelated)

rajasekarm pushed a commit to rajasekarm/babel that referenced this pull request Feb 17, 2020
babel/babel-archive already includes the last working version of these presets (v7.0.0-beta.52), and they have been throwing since 7.0.0
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 8, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants