Respect preserveComments option in tempate.ast() #11112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
approved these changes
Feb 9, 2020
| @@ -219,7 +231,7 @@ describe("@babel/template", function() { | |||
| }); | |||
| }); | |||
|
|
|||
| describe.only(".syntacticPlaceholders", () => { | |||
| describe(".syntacticPlaceholders", () => { | |||
There was a problem hiding this comment.
We should probably lint for this 😬
There was a problem hiding this comment.
Actually, it looks like we should be linting for this already: https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/no-focused-tests.md is a recommended rule. 🤔
There was a problem hiding this comment.
We added it yesterday 😛
#11119
nicolo-ribaudo
added
pkg: template
PR: Bug Fix 🐛
kaicataldo
approved these changes
Feb 10, 2020
existentialism
approved these changes
Feb 10, 2020
|
Thanks! |
rajasekarm
pushed a commit
to rajasekarm/babel
that referenced
this pull request
Feb 17, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validate(opts)addedpreserveComments: falsewhenpreserveCommentswas not present in the validated options. This caused theNO_PLACEHOLDERoptions inbuilder.jsto containpreserveComments: false. So sinceNO_PLACEHOLDERlater is merged in to the rest of the options given to template.ast() the preserveComments option was always set to false.This PR changes
validate(opts)so it keepspreserveCommentsundefined if it was null/undefined.