Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse BigInts by default #11117

Merged
merged 1 commit into from Mar 16, 2020
Merged

Parse BigInts by default #11117

merged 1 commit into from Mar 16, 2020

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Feb 9, 2020 •
edited

Q                       A
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature? Yes
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

According to https://github.com/tc39/proposals/blob/master/finished-proposals.md, they have been stage 4 since June. This should have been in the 7.8.0 release 🙃.

@nicolo-ribaudo nicolo-ribaudo added PR: New Feature 🚀 A type of pull request used for our changelog categories pkg: parser Spec: BigInt labels Feb 9, 2020
@nicolo-ribaudo nicolo-ribaudo added this to the v7.9.0 milestone Feb 9, 2020
JLHwung
JLHwung approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also remove bigInt from packages/babel-parser/typings/babel-parser.d.ts in v8.

kaicataldo
kaicataldo approved these changes Feb 10, 2020
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@nicolo-ribaudo nicolo-ribaudo added the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Feb 10, 2020
@nicolo-ribaudo nicolo-ribaudo merged commit 2bce1e5 into babel:master Mar 16, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the bigint-default branch March 16, 2020 21:59
This was referenced Mar 22, 2020
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Mar 30, 2020
Open
Open
Open
Open
This was referenced Apr 11, 2020
Merged
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Apr 17, 2020
Open
Open
Open
Open
Open
This was referenced Apr 24, 2020
Open
Open
Open
Closed
Open
Open
Merged
This was referenced May 2, 2020
Open
Merged
Open
Closed
Open
Open
Open
Open
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 16, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@JLHwung JLHwung JLHwung approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release Spec: BigInt
Projects
None yet
Milestone
v7.9.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nicolo-ribaudo @existentialism @JLHwung @kaicataldo